Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward RTP/RTCP messages unconditionally if there is only one track #1023

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

wusspuss
Copy link

No description provided.

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implements forwarding for RTP packets but not for RTCP ones. I think the check for single-track case should be at the beginning of dispatchMedia to not even go through the SSRC lookup if there is only one track. In that case mTracksMutex should be locked for the entire method.

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thank you.

@paullouisageneau paullouisageneau changed the title no ssrc and only one track Forward RTP/RTCP messages unconditionally if there is only one track Nov 13, 2023
@paullouisageneau paullouisageneau merged commit 3681569 into paullouisageneau:master Nov 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants