Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing methods of RtcpReportBlock #1013

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Implement missing methods of RtcpReportBlock #1013

merged 2 commits into from
Oct 25, 2023

Conversation

ognkrmms
Copy link
Contributor

This PR implements setPacketsLost, getLossPercentage and getPacketLostCount methods of RtcpReportBlock that we need for receiver reports.

I also added extendedHighestSeqNo method to return the extended sequence number of RtcpReportBlock in case one wants to access the the whole thing.

@ognkrmms
Implement setPacketsLost, getLossPercentage and getPacketLostCount me…
a07508a 
…thods of RtcpReportBlock. Add extendedHighestSeqNo method to return the extended seqNo of RtcpReportBlock
paullouisageneau
paullouisageneau reviewed Oct 24, 2023
View reviewed changes
src/rtp.cpp Outdated Show resolved Hide resolved
paullouisageneau
paullouisageneau reviewed Oct 24, 2023
View reviewed changes
src/rtp.cpp Outdated Show resolved Hide resolved
paullouisageneau
paullouisageneau reviewed Oct 24, 2023
View reviewed changes
Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I think it's a good opportunity to change some of the naming.

paullouisageneau
paullouisageneau approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@paullouisageneau paullouisageneau merged commit d99e501 into paullouisageneau:master Oct 25, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullouisageneau paullouisageneau paullouisageneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ognkrmms @paullouisageneau