Merge pull request #1264 from paullouisageneau/reword-send-exceptions

Reword send exceptions for clarity
paullouisageneau · Oct 1, 2024 · c1c63ae · c1c63ae
2 parents 4bf08fd + 99fca9a
commit c1c63ae
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/impl/datachannel.cpp b/src/impl/datachannel.cpp
@@ -185,9 +185,12 @@ bool DataChannel::outgoing(message_ptr message) {
 		std::shared_lock lock(mMutex);
 		transport = mSctpTransport.lock();
 
-		if (!transport || mIsClosed)
+		if (mIsClosed)
 			throw std::runtime_error("DataChannel is closed");
 
+		if (!transport)
+			throw std::runtime_error("DataChannel not open");
+
 		if (!mStream.has_value())
 			throw std::logic_error("DataChannel has no stream assigned");
 

diff --git a/src/impl/track.cpp b/src/impl/track.cpp
@@ -202,7 +202,7 @@ bool Track::transportSend([[maybe_unused]] message_ptr message) {
 		std::shared_lock lock(mMutex);
 		transport = mDtlsSrtpTransport.lock();
 		if (!transport)
-			throw std::runtime_error("Track is closed");
+			throw std::runtime_error("Track is not open");
 
 		// Set recommended medium-priority DSCP value
 		// See https://www.rfc-editor.org/rfc/rfc8837.html#section-5