Fix PeerConnection::checkFingerprint

paullouisageneau · Jan 10, 2024 · 97c273b · 97c273b
1 parent 42ec088
commit 97c273b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/impl/peerconnection.cpp b/src/impl/peerconnection.cpp
@@ -423,8 +423,11 @@ void PeerConnection::rollbackLocalDescription() {
 
 bool PeerConnection::checkFingerprint(const std::string &fingerprint) const {
 	std::lock_guard lock(mRemoteDescriptionMutex);
-	auto expectedFingerprint = mRemoteDescription && mRemoteDescription->fingerprint() ? mRemoteDescription->fingerprint()->value : "";
-	if (expectedFingerprint == fingerprint) {
+	if (!mRemoteDescription || !mRemoteDescription->fingerprint())
+		return false;
+
+	auto expectedFingerprint = mRemoteDescription->fingerprint()->value;
+	if (expectedFingerprint  == fingerprint) {
 		PLOG_VERBOSE << "Valid fingerprint \"" << fingerprint << "\"";
 		return true;
 	}