Prevent any state change after close in PeerConnection (Fix #600)

paullouisageneau · Apr 15, 2022 · 8712a64 · 8712a64
1 parent 731f68a
commit 8712a64
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/impl/peerconnection.cpp b/src/impl/peerconnection.cpp
@@ -1126,12 +1126,13 @@ bool PeerConnection::changeState(State newState) {
 	s << newState;
 	PLOG_INFO << "Changed state to " << s.str();
 
-	if (newState == State::Closed)
-		stateChangeCallback(State::Closed); // synchronous
-	else
+	if (newState == State::Closed) {
+		auto callback = std::move(stateChangeCallback); // steal the callback
+		callback(State::Closed);                        // call it synchronously
+	} else {
 		mProcessor.enqueue(&PeerConnection::trigger<State>, shared_from_this(), stateChangeCallback,
 		                   newState);
-
+	}
 	return true;
 }