Pass mesh as const& in write*obj to avoid unnecessary copy

patrikhuber · Dec 4, 2019 · bba26ff · bba26ff
1 parent 13f3add
commit bba26ff
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/include/eos/core/write_obj.hpp b/include/eos/core/write_obj.hpp
@@ -40,7 +40,7 @@ namespace core {
  * @param[in] mesh The mesh to save as obj.
  * @param[in] filename Output filename (including ".obj").
  */
-inline void write_obj(Mesh mesh, std::string filename)
+inline void write_obj(const Mesh& mesh, std::string filename)
 {
     assert(mesh.vertices.size() == mesh.colors.size() || mesh.colors.empty());
     assert(mesh.tvi.size() == mesh.tti.size() || mesh.tti.empty());
@@ -112,7 +112,7 @@ inline void write_obj(Mesh mesh, std::string filename)
  * @param[in] mesh The mesh to save as obj.
  * @param[in] filename Output filename, including .obj.
  */
-inline void write_textured_obj(Mesh mesh, std::string filename)
+inline void write_textured_obj(const Mesh& mesh, std::string filename)
 {
     assert(mesh.vertices.size() == mesh.colors.size() || mesh.colors.empty());
     assert(!mesh.texcoords.empty());