Fixed #12 - Bug when $_GET['user'] or $_POST['user'] is empty

patrickbussmann · Jul 14, 2020 · 413d7dd · 413d7dd
1 parent daa9d05
commit 413d7dd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/Provider/Apple.php b/src/Provider/Apple.php
@@ -113,7 +113,7 @@ protected function getAuthorizationParameters(array $options)
     protected function fetchResourceOwnerDetails(AccessToken $token)
     {
         return json_decode(array_key_exists('user', $_GET) ? $_GET['user']
-            : (array_key_exists('user', $_POST) ? $_POST['user'] : '[]'), true);
+            : (array_key_exists('user', $_POST) ? $_POST['user'] : '[]'), true) ?: [];
     }
 
     /**

diff --git a/test/src/Provider/AppleTest.php b/test/src/Provider/AppleTest.php
@@ -171,7 +171,7 @@ public function testGetAccessToken()
 	    ]);
     }
 
-	public function testFechtingOwnerDetails()
+	public function testFetchingOwnerDetails()
 	{
 		$class = new \ReflectionClass($this->provider);
 		$method = $class->getMethod('fetchResourceOwnerDetails');
@@ -186,6 +186,21 @@ public function testFechtingOwnerDetails()
 		$this->assertEquals($arr, $data);
 	}
 
+    /**
+     * @see https://github.com/patrickbussmann/oauth2-apple/issues/12
+     */
+	public function testFetchingOwnerDetailsIssue12()
+	{
+		$class = new \ReflectionClass($this->provider);
+		$method = $class->getMethod('fetchResourceOwnerDetails');
+		$method->setAccessible(true);
+
+        $_POST['user'] = '';
+		$data = $method->invokeArgs($this->provider, [new AccessToken(['access_token' => 'hello'])]);
+
+		$this->assertEquals([], $data);
+	}
+
 	/**
 	 * @expectedException Exception
 	 */