Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header as Interface #545

Closed
wants to merge 2 commits into from
Closed

Header as Interface #545

wants to merge 2 commits into from

Conversation

DavidBadura
Copy link
Member

This was my idea of the header implementation. But we went away with the attributes and metadata.

I created the PR to have further discussions to decide how to proceed. There are currently three options:

  1. Further expand Metadata Loader: Revisit internal header loading #542
  2. Mixing between array and attribute config: load the internal header automatically #541
  3. Only php array config (without Metadata/Hydrator): this PR

@DavidBadura DavidBadura changed the title Simplify headers Header as Interface Mar 18, 2024
Copy link

github-actions bot commented Mar 18, 2024

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------------+------------+
|                           | time (kde mode)                   | memory                       |
+---------------------------+-----------------+-----------------+-----------------+------------+
| subject                   | Tag: <current>  | Tag: base       | Tag: <current>  | Tag: base  |
+---------------------------+-----------------+-----------------+-----------------+------------+
| benchHandle10000Events () | 3.282s (±0.00%) | 3.268s (±0.00%) | 37.928mb        | 39.066mb   |
+---------------------------+-----------------+-----------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.684ms (±0.00%)   | 5.548ms (±0.00%)   | 41.610mb        | 42.531mb   |
| benchSave10000Events () | 629.928ms (±0.00%) | 645.917ms (±0.00%) | 41.898mb        | 42.809mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 150.553ms (±0.00%) | 152.836ms (±0.00%) | 37.489mb        | 38.666mb   |
| benchSave1Event ()                     | 942.600μs (±0.00%) | 925.000μs (±0.00%) | 37.489mb        | 38.666mb   |
| benchSave10000Events ()                | 462.537ms (±0.00%) | 473.298ms (±0.00%) | 37.766mb        | 38.932mb   |
| benchSave10000Aggregates ()            | 9.720s (±0.00%)    | 10.010s (±0.00%)   | 37.489mb        | 38.666mb   |
| benchSave10000AggregatesTransaction () | 7.491s (±0.00%)    | 7.518s (±0.00%)    | 37.489mb        | 38.666mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 151.526ms (±0.00%) | 156.995ms (±0.00%) | 37.507mb        | 38.663mb   |
| benchLoad10000Events ()                | 533.100μs (±0.00%) | 523.400μs (±0.00%) | 37.507mb        | 38.663mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura closed this Apr 9, 2024
@DavidBadura DavidBadura deleted the simplify-headers branch May 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant