Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show command & add 'end'/'next' method in stream interface #468

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Jan 15, 2024

I can't use foreach in this context because foreach always starts from the beginning. And that even leads to an error since we're working with generators. I fixed the problem by adding the necessary methods to the interface so that the command works as intended.

@DavidBadura DavidBadura added bug Something isn't working enhancement New feature or request labels Jan 15, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Jan 15, 2024
Copy link

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 121.272ms (±0.00%) | 122.510ms (±0.00%) | 32.627mb        | 32.625mb   |
| benchSave1Event ()                     | 1.109ms (±0.00%)   | 991.850μs (±0.00%) | 32.627mb        | 32.625mb   |
| benchSave10000Events ()                | 277.798ms (±0.00%) | 280.441ms (±0.00%) | 32.853mb        | 32.851mb   |
| benchSave10000Aggregates ()            | 10.237s (±0.00%)   | 10.350s (±0.00%)   | 32.627mb        | 32.626mb   |
| benchSave10000AggregatesTransaction () | 760.526ms (±0.00%) | 769.605ms (±0.00%) | 32.627mb        | 32.626mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.343ms (±0.00%)   | 2.419ms (±0.00%)   | 36.010mb        | 36.009mb   |
| benchSave10000Events () | 314.102ms (±0.00%) | 321.893ms (±0.00%) | 36.277mb        | 36.277mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.331ms (±0.00%)   | 1.426ms (±0.00%)   | 8.128mb         | 8.126mb    |
| benchSave10000Events () | 437.454ms (±0.00%) | 446.972ms (±0.00%) | 33.459mb        | 33.458mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 126.846ms (±0.00%) | 122.099ms (±0.00%) | 32.648mb        | 32.646mb   |
| benchLoad10000Events ()                | 198.900μs (±0.00%) | 213.800μs (±0.00%) | 32.648mb        | 32.646mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit f7e46d5 into 3.0.x Jan 17, 2024
31 of 33 checks passed
@DavidBadura DavidBadura deleted the fix-show-command branch January 17, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants