Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better projection error handling #449

Merged
merged 3 commits into from
Jan 2, 2024
Merged

better projection error handling #449

merged 3 commits into from
Jan 2, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Dec 24, 2023 •
edited
Loading

  • refactor projection errors
  • implement retry logic

@DavidBadura DavidBadura added bug Something isn't working enhancement New feature or request BC-Break labels Dec 24, 2023
@DavidBadura DavidBadura added this to the 3.0.0 milestone Dec 24, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 24, 2023 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 124.924ms (±0.00%) | 128.431ms (±0.00%) | 31.983mb        | 31.982mb   |
| benchSave1Event ()                     | 1.136ms (±0.00%)   | 1.407ms (±0.00%)   | 31.982mb        | 31.982mb   |
| benchSave10000Events ()                | 276.089ms (±0.00%) | 273.293ms (±0.00%) | 32.206mb        | 32.206mb   |
| benchSave10000Aggregates ()            | 11.455s (±0.00%)   | 12.407s (±0.00%)   | 31.983mb        | 31.983mb   |
| benchSave10000AggregatesTransaction () | 638.897ms (±0.00%) | 644.992ms (±0.00%) | 31.983mb        | 31.983mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.302ms (±0.00%)   | 2.318ms (±0.00%)   | 35.370mb        | 35.370mb   |
| benchSave10000Events () | 355.893ms (±0.00%) | 352.458ms (±0.00%) | 35.638mb        | 35.638mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.491ms (±0.00%)   | 1.442ms (±0.00%)   | 7.481mb         | 7.472mb    |
| benchSave10000Events () | 459.653ms (±0.00%) | 447.499ms (±0.00%) | 32.812mb        | 32.803mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 127.239ms (±0.00%) | 124.536ms (±0.00%) | 32.007mb        | 32.007mb   |
| benchLoad10000Events ()                | 204.300μs (±0.00%) | 192.050μs (±0.00%) | 32.007mb        | 32.007mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the better-projection-error-handling branch from 5bc4675 to 256b66c Compare December 29, 2023 10:02
@DavidBadura DavidBadura marked this pull request as ready for review December 29, 2023 10:05
@DavidBadura DavidBadura force-pushed the better-projection-error-handling branch from 77dd801 to cc91df8 Compare December 29, 2023 15:00
@DavidBadura DavidBadura merged commit 4b966ea into 3.0.x Jan 2, 2024
31 of 33 checks passed
@DavidBadura DavidBadura deleted the better-projection-error-handling branch January 2, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura