Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store projection error objects #436

Merged
merged 2 commits into from
Dec 14, 2023
Merged

store projection error objects #436

merged 2 commits into from
Dec 14, 2023

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Dec 13, 2023 •
edited by DanielBadura
Loading

fix #397

@DavidBadura DavidBadura added the enhancement New feature or request label Dec 13, 2023
@DavidBadura DavidBadura added this to the 3.0.0 milestone Dec 13, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 135.204ms (±0.00%) | 135.525ms (±0.00%) | 13.758mb        | 13.758mb   |
| benchLoad10000Events ()                | 191.950μs (±0.00%) | 190.600μs (±0.00%) | 13.758mb        | 13.758mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 135.507ms (±0.00%) | 143.831ms (±0.00%) | 13.730mb        | 13.730mb   |
| benchSave1Event ()      | 1.023ms (±0.00%)   | 1.103ms (±0.00%)   | 13.730mb        | 13.730mb   |
| benchSave10000Events () | 509.193ms (±0.00%) | 503.268ms (±0.00%) | 13.736mb        | 13.736mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+--------------------------+--------------------+--------------------+-----------------+------------+
|                          | time (kde mode)                         | memory                       |
+--------------------------+--------------------+--------------------+-----------------+------------+
| subject                  | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()  | 2.383ms (±0.00%)   | 2.412ms (±0.00%)   | 17.050mb        | 17.050mb   |
| benchWrite10000Events () | 593.710ms (±0.00%) | 596.479ms (±0.00%) | 17.056mb        | 17.056mb   |
+--------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.331ms (±0.00%)   | 1.331ms (±0.00%)   | 7.459mb         | 7.457mb    |
| benchSave10000Events () | 692.980ms (±0.00%) | 687.252ms (±0.00%) | 14.851mb        | 14.849mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the better-projection-errors branch from d18b4d0 to 355671a Compare December 13, 2023 13:43
@DanielBadura DanielBadura linked an issue Dec 13, 2023 that may be closed by this pull request
A better exception processing for the projections #397
Closed
@DavidBadura DavidBadura force-pushed the better-projection-errors branch from 355671a to 92ea207 Compare December 13, 2023 14:42
@DavidBadura DavidBadura merged commit 320a4e3 into 3.0.x Dec 14, 2023
30 of 31 checks passed
@DavidBadura DavidBadura deleted the better-projection-errors branch December 23, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

A better exception processing for the projections
2 participants
@DavidBadura @DanielBadura