Merge pull request #453 from patchlevel/readonly-attributes

change attributes into readonly public objects

src/Attribute/Aggregate.php

@@ -10,12 +10,7 @@
 final class Aggregate
 {
     public function __construct(
-        private string $name,
+        public readonly string $name,
     ) {
     }
-
-    public function name(): string
-    {
-        return $this->name;
-    }
 }

src/Attribute/Apply.php

@@ -11,13 +11,7 @@ final class Apply
 {
     /** @param class-string|null $eventClass */
     public function __construct(
-        private string|null $eventClass = null,
+        public readonly string|null $eventClass = null,
     ) {
     }
-
-    /** @return class-string|null */
-    public function eventClass(): string|null
-    {
-        return $this->eventClass;
-    }
 }

src/Attribute/Event.php

@@ -10,12 +10,7 @@
 final class Event
 {
     public function __construct(
-        private string $name,
+        public readonly string $name,
     ) {
     }
-
-    public function name(): string
-    {
-        return $this->name;
-    }
 }

src/Attribute/Projector.php

@@ -10,18 +10,8 @@
 final class Projector
 {
     public function __construct(
-        private string $name,
-        private int $version = 0,
+        public readonly string $name,
+        public readonly int $version = 0,
     ) {
     }
-
-    public function name(): string
-    {
-        return $this->name;
-    }
-
-    public function version(): int
-    {
-        return $this->version;
-    }
 }

src/Attribute/Snapshot.php

@@ -10,24 +10,9 @@
 final class Snapshot
 {
     public function __construct(
-        private string $name,
-        private int|null $batch = null,
-        private string|null $version = null,
+        public readonly string $name,
+        public readonly int|null $batch = null,
+        public readonly string|null $version = null,
     ) {
     }
-
-    public function name(): string
-    {
-        return $this->name;
-    }
-
-    public function batch(): int|null
-    {
-        return $this->batch;
-    }
-
-    public function version(): string|null
-    {
-        return $this->version;
-    }
 }

src/Attribute/Subscribe.php

@@ -11,13 +11,7 @@ final class Subscribe
 {
     /** @param class-string $eventClass */
     public function __construct(
-        private string $eventClass,
+        public readonly string $eventClass,
     ) {
     }
-
-    /** @return class-string */
-    public function eventClass(): string
-    {
-        return $this->eventClass;
-    }
 }

src/Attribute/SuppressMissingApply.php

@@ -12,29 +12,20 @@ final class SuppressMissingApply
     public const ALL = '*';
 
     /** @var list<class-string> */
-    private array $suppressEvents = [];
-    private bool $suppressAll = false;
+    public readonly array $suppressEvents;
+    public readonly bool $suppressAll;
 
     /** @param list<class-string>|self::ALL $suppress */
     public function __construct(string|array $suppress)
     {
         if ($suppress === self::ALL) {
+            $this->suppressEvents = [];
             $this->suppressAll = true;
 
             return;
         }
 
         $this->suppressEvents = $suppress;
-    }
-
-    /** @return list<class-string> */
-    public function suppressEvents(): array
-    {
-        return $this->suppressEvents;
-    }
-
-    public function suppressAll(): bool
-    {
-        return $this->suppressAll;
+        $this->suppressAll = false;
     }
 }

src/EventBus/Subscriber.php

@@ -41,7 +41,7 @@ private function init(): void
 
             foreach ($attributes as $attribute) {
                 $instance = $attribute->newInstance();
-                $eventClass = $instance->eventClass();
+                $eventClass = $instance->eventClass;
 
                 if (array_key_exists($eventClass, $this->subscribeMethods)) {
                     throw new DuplicateSubscribeMethod(

src/Metadata/AggregateRoot/AttributeAggregateRootMetadataFactory.php

@@ -73,13 +73,13 @@ private function findSuppressMissingApply(ReflectionClass $reflector): array
         foreach ($attributes as $attribute) {
             $instance = $attribute->newInstance();
 
-            if ($instance->suppressAll()) {
+            if ($instance->suppressAll) {
                 $suppressAll = true;
 
                 continue;
             }
 
-            foreach ($instance->suppressEvents() as $event) {
+            foreach ($instance->suppressEvents as $event) {
                 $suppressEvents[$event] = true;
             }
         }
@@ -97,7 +97,7 @@ private function findAggregateName(ReflectionClass $reflector): string
 
         $aggregateAttribute = $attributeReflectionList[0]->newInstance();
 
-        return $aggregateAttribute->name();
+        return $aggregateAttribute->name;
     }
 
     private function findIdProperty(ReflectionClass $reflector): string
@@ -128,9 +128,9 @@ private function findSnapshot(ReflectionClass $reflector): Snapshot|null
         $attribute = $attributeReflectionList[0]->newInstance();
 
         return new Snapshot(
-            $attribute->name(),
-            $attribute->batch(),
-            $attribute->version(),
+            $attribute->name,
+            $attribute->batch,
+            $attribute->version,
         );
     }
 
@@ -159,7 +159,7 @@ private function findApplyMethods(ReflectionClass $reflector, string $aggregate)
 
             foreach ($attributes as $attribute) {
                 $applyAttribute = $attribute->newInstance();
-                $eventClass = $applyAttribute->eventClass();
+                $eventClass = $applyAttribute->eventClass;
 
                 if ($eventClass !== null) {
                     $hasOneNonEmptyApply = true;

src/Metadata/AggregateRoot/AttributeAggregateRootRegistryFactory.php

@@ -33,7 +33,7 @@ public function create(array $paths): AggregateRootRegistry
                 throw new NoAggregateRoot($class);
             }
 
-            $aggregateName = $attributes[0]->newInstance()->name();
+            $aggregateName = $attributes[0]->newInstance()->name;
 
             $result[$aggregateName] = $class;
         }

src/Metadata/Event/AttributeEventMetadataFactory.php

@@ -32,10 +32,9 @@ public function metadata(string $event): EventMetadata
         }
 
         $eventAttribute = $attributeReflectionList[0]->newInstance();
-        $eventName = $eventAttribute->name();
 
         $this->eventMetadata[$event] = new EventMetadata(
-            $eventName,
+            $eventAttribute->name,
             $this->splitStream($reflectionClass),
         );
 

src/Metadata/Event/AttributeEventRegistryFactory.php

@@ -27,7 +27,7 @@ public function create(array $paths): EventRegistry
                 continue;
             }
 
-            $eventName = $attributes[0]->newInstance()->name();
+            $eventName = $attributes[0]->newInstance()->name;
 
             $result[$eventName] = $class;
         }

src/Metadata/Projector/AttributeProjectorMetadataFactory.php

@@ -32,7 +32,7 @@ public function metadata(string $projector): ProjectorMetadata
             throw new ClassIsNotAProjector($projector);
         }
 
-        $projection = $attributes[0]->newInstance();
+        $projectorInfo = $attributes[0]->newInstance();
 
         $methods = $reflector->getMethods();
 
@@ -45,7 +45,7 @@ public function metadata(string $projector): ProjectorMetadata
 
             foreach ($attributes as $attribute) {
                 $instance = $attribute->newInstance();
-                $eventClass = $instance->eventClass();
+                $eventClass = $instance->eventClass;
 
                 if (array_key_exists($eventClass, $subscribeMethods)) {
                     throw new DuplicateSubscribeMethod(
@@ -87,8 +87,8 @@ public function metadata(string $projector): ProjectorMetadata
         }
 
         $metadata = new ProjectorMetadata(
-            $projection->name(),
-            $projection->version(),
+            $projectorInfo->name,
+            $projectorInfo->version,
             $subscribeMethods,
             $createMethod,
             $dropMethod,

tests/Unit/Attribute/SuppressMissingApplyTest.php

@@ -15,15 +15,15 @@ public function testSuppressEvents(): void
     {
         $attribute = new SuppressMissingApply([ProfileCreated::class]);
 
-        self::assertSame([ProfileCreated::class], $attribute->suppressEvents());
-        self::assertSame(false, $attribute->suppressAll());
+        self::assertSame([ProfileCreated::class], $attribute->suppressEvents);
+        self::assertSame(false, $attribute->suppressAll);
     }
 
     public function testSuppressAll(): void
     {
         $attribute = new SuppressMissingApply(SuppressMissingApply::ALL);
 
-        self::assertSame([], $attribute->suppressEvents());
-        self::assertSame(true, $attribute->suppressAll());
+        self::assertSame([], $attribute->suppressEvents);
+        self::assertSame(true, $attribute->suppressAll);
     }
 }