Fix customHeader method to actually check for the header existing

patchlevel · Mar 8, 2024 · f708b10 · f708b10
1 parent f6f7ce9
commit f708b10
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/EventBus/Message.php b/src/EventBus/Message.php
@@ -167,7 +167,7 @@ public function withArchived(bool $value): self
 
     public function customHeader(string $name): mixed
     {
-        if (array_keys($this->customHeaders, $name)) {
+        if (!array_key_exists($name, $this->customHeaders)) {
             throw HeaderNotFound::custom($name);
         }
 

diff --git a/tests/Unit/EventBus/MessageTest.php b/tests/Unit/EventBus/MessageTest.php
@@ -119,11 +119,16 @@ public function testCustomHeaders(): void
             ->withAggregateId('1')
             ->withPlayhead(1)
             ->withRecordedOn($recordedAt)
-            ->withCustomHeader('custom-field', 'foo-bar');
+            ->withCustomHeader('custom-field', 'foo-bar')
+            ->withCustomHeader('valueiskey', 'valueiskey')
+        ;
 
         self::assertEquals(
-            ['custom-field' => 'foo-bar'],
+            ['custom-field' => 'foo-bar', 'valueiskey' => 'valueiskey'],
             $message->customHeaders(),
         );
+
+        self::assertEquals('foo-bar', $message->customHeader('custom-field'));
+        self::assertEquals('valueiskey', $message->customHeader('valueiskey'));
     }
 }