Merge pull request #518 from patchlevel/use-postgres-in-benchmarks

use postgres in benchmarks
patchlevel · Mar 3, 2024 · f10a683 · f10a683
2 parents 569fcc1 + 0217853
commit f10a683
Show file tree

Hide file tree

Showing 14 changed files with 42 additions and 80 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -11,6 +11,19 @@ jobs:
 
     runs-on: ${{ matrix.operating-system }}
 
+    services:
+      postgres:
+        # Docker Hub image
+        image: "postgres:16.1"
+        # Provide the password for postgres
+        env:
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: eventstore
+        options: >-
+          --health-cmd "pg_isready"
+        ports:
+          - "5432:5432"
+
     strategy:
       matrix:
         dependencies:
@@ -20,6 +33,9 @@ jobs:
         operating-system:
           - "ubuntu-latest"
 
+    env:
+      DB_URL: 'pdo-pgsql://postgres:postgres@localhost:5432/eventstore?charset=utf8'
+
     steps:
       - name: "Install PHP"
         uses: "shivammathur/[email protected]"

diff --git a/Makefile b/Makefile
@@ -43,10 +43,10 @@ test: phpunit
 
 .PHONY: benchmark
 benchmark: vendor                                                               ## run benchmarks
-	vendor/bin/phpbench run tests/Benchmark --report=default
+	DB_URL=sqlite3:///:memory: vendor/bin/phpbench run tests/Benchmark --report=default
 
 .PHONY: benchmark-diff-test
-benchmark-diff-test: vendor                                                          ## run benchmarks
+benchmark-diff-test: vendor                                                   	## run benchmarks
 	vendor/bin/phpbench run tests/Benchmark --revs=1 --report=default --progress=none --tag=base
 	vendor/bin/phpbench run tests/Benchmark --revs=1 --report=diff --progress=none --ref=base
 

diff --git a/tests/Benchmark/BasicImplementation/data/.gitignore b/tests/Benchmark/BasicImplementation/data/.gitignore
diff --git a/tests/Benchmark/ProjectionistBench.php b/tests/Benchmark/ProjectionistBench.php
@@ -4,8 +4,6 @@
 
 namespace Patchlevel\EventSourcing\Tests\Benchmark;
 
-use Doctrine\DBAL\Driver\PDO\SQLite\Driver;
-use Doctrine\DBAL\DriverManager;
 use Patchlevel\EventSourcing\Aggregate\AggregateRootId;
 use Patchlevel\EventSourcing\EventBus\DefaultEventBus;
 use Patchlevel\EventSourcing\EventBus\EventBus;
@@ -23,16 +21,12 @@
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\Processor\SendEmailProcessor;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\ProfileId;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\Projection\ProfileProjector;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use PhpBench\Attributes as Bench;
 
-use function file_exists;
-use function unlink;
-
 #[Bench\BeforeMethods('setUp')]
 final class ProjectionistBench
 {
-    private const DB_PATH = __DIR__ . '/BasicImplementation/data/db.sqlite3';
-
     private Store $store;
     private EventBus $bus;
     private Repository $repository;
@@ -43,14 +37,7 @@ final class ProjectionistBench
 
     public function setUp(): void
     {
-        if (file_exists(self::DB_PATH)) {
-            unlink(self::DB_PATH);
-        }
-
-        $connection = DriverManager::getConnection([
-            'driverClass' => Driver::class,
-            'path' => self::DB_PATH,
-        ]);
+        $connection = DbalManager::createConnection();
 
         $this->bus = DefaultEventBus::create();
 
@@ -96,7 +83,7 @@ public function setUp(): void
         );
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchHandle10000Events(): void
     {
         $this->projectionist->boot();

diff --git a/tests/Benchmark/SimpleSetupBench.php b/tests/Benchmark/SimpleSetupBench.php
@@ -4,8 +4,6 @@
 
 namespace Patchlevel\EventSourcing\Tests\Benchmark;
 
-use Doctrine\DBAL\Driver\PDO\SQLite\Driver;
-use Doctrine\DBAL\DriverManager;
 use Patchlevel\EventSourcing\Aggregate\AggregateRootId;
 use Patchlevel\EventSourcing\EventBus\DefaultEventBus;
 use Patchlevel\EventSourcing\EventBus\EventBus;
@@ -17,16 +15,12 @@
 use Patchlevel\EventSourcing\Store\Store;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\Aggregate\Profile;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\ProfileId;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use PhpBench\Attributes as Bench;
 
-use function file_exists;
-use function unlink;
-
 #[Bench\BeforeMethods('setUp')]
 final class SimpleSetupBench
 {
-    private const DB_PATH = __DIR__ . '/BasicImplementation/data/db.sqlite3';
-
     private Store $store;
     private EventBus $bus;
     private Repository $repository;
@@ -35,14 +29,7 @@ final class SimpleSetupBench
 
     public function setUp(): void
     {
-        if (file_exists(self::DB_PATH)) {
-            unlink(self::DB_PATH);
-        }
-
-        $connection = DriverManager::getConnection([
-            'driverClass' => Driver::class,
-            'path' => self::DB_PATH,
-        ]);
+        $connection = DbalManager::createConnection();
 
         $this->bus = DefaultEventBus::create();
 
@@ -72,20 +59,20 @@ public function setUp(): void
         $this->repository->save($profile);
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchLoad10000Events(): void
     {
         $this->repository->load($this->id);
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchSave1Event(): void
     {
         $profile = Profile::create(ProfileId::v7(), 'Peter');
         $this->repository->save($profile);
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchSave10000Events(): void
     {
         $profile = Profile::create(ProfileId::v7(), 'Peter');
@@ -106,7 +93,7 @@ public function benchSave10000Aggregates(): void
         }
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchSave10000AggregatesTransaction(): void
     {
         $this->store->transactional(function (): void {

diff --git a/tests/Benchmark/SnapshotsBench.php b/tests/Benchmark/SnapshotsBench.php
@@ -4,8 +4,6 @@
 
 namespace Patchlevel\EventSourcing\Tests\Benchmark;
 
-use Doctrine\DBAL\Driver\PDO\SQLite\Driver;
-use Doctrine\DBAL\DriverManager;
 use Patchlevel\EventSourcing\Aggregate\AggregateRootId;
 use Patchlevel\EventSourcing\EventBus\DefaultEventBus;
 use Patchlevel\EventSourcing\EventBus\EventBus;
@@ -20,16 +18,12 @@
 use Patchlevel\EventSourcing\Store\Store;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\Aggregate\Profile;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\ProfileId;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use PhpBench\Attributes as Bench;
 
-use function file_exists;
-use function unlink;
-
 #[Bench\BeforeMethods('setUp')]
 final class SnapshotsBench
 {
-    private const DB_PATH = __DIR__ . '/BasicImplementation/data/db.sqlite3';
-
     private Store $store;
     private EventBus $bus;
     private SnapshotStore $snapshotStore;
@@ -41,14 +35,7 @@ final class SnapshotsBench
 
     public function setUp(): void
     {
-        if (file_exists(self::DB_PATH)) {
-            unlink(self::DB_PATH);
-        }
-
-        $connection = DriverManager::getConnection([
-            'driverClass' => Driver::class,
-            'path' => self::DB_PATH,
-        ]);
+        $connection = DbalManager::createConnection();
 
         $this->bus = DefaultEventBus::create();
 
@@ -82,14 +69,14 @@ public function setUp(): void
         $this->snapshotStore->save($profile);
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchLoad10000EventsMissingSnapshot(): void
     {
         $this->adapter->clear();
         $this->repository->load($this->id);
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchLoad10000Events(): void
     {
         $this->repository->load($this->id);

diff --git a/tests/Benchmark/SplitStreamBench.php b/tests/Benchmark/SplitStreamBench.php
@@ -4,8 +4,6 @@
 
 namespace Patchlevel\EventSourcing\Tests\Benchmark;
 
-use Doctrine\DBAL\Driver\PDO\SQLite\Driver;
-use Doctrine\DBAL\DriverManager;
 use Patchlevel\EventSourcing\Aggregate\AggregateRootId;
 use Patchlevel\EventSourcing\EventBus\DefaultEventBus;
 use Patchlevel\EventSourcing\EventBus\EventBus;
@@ -15,39 +13,27 @@
 use Patchlevel\EventSourcing\Repository\Repository;
 use Patchlevel\EventSourcing\Schema\DoctrineSchemaDirector;
 use Patchlevel\EventSourcing\Serializer\DefaultEventSerializer;
-use Patchlevel\EventSourcing\Snapshot\SnapshotStore;
 use Patchlevel\EventSourcing\Store\DoctrineDbalStore;
 use Patchlevel\EventSourcing\Store\Store;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\Aggregate\Profile;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\ProfileId;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use PhpBench\Attributes as Bench;
 
-use function file_exists;
 use function sprintf;
-use function unlink;
 
 #[Bench\BeforeMethods('setUp')]
 final class SplitStreamBench
 {
-    private const DB_PATH = __DIR__ . '/BasicImplementation/data/db.sqlite3';
-
     private Store $store;
     private EventBus $bus;
-    private SnapshotStore $snapshotStore;
     private Repository $repository;
 
     private AggregateRootId $id;
 
     public function setUp(): void
     {
-        if (file_exists(self::DB_PATH)) {
-            unlink(self::DB_PATH);
-        }
-
-        $connection = DriverManager::getConnection([
-            'driverClass' => Driver::class,
-            'path' => self::DB_PATH,
-        ]);
+        $connection = DbalManager::createConnection();
 
         $this->bus = DefaultEventBus::create();
 
@@ -94,14 +80,14 @@ public function provideData(): void
         $this->repository->save($profile);
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     #[Bench\BeforeMethods('provideData')]
     public function benchLoad10000Events(): void
     {
         $this->repository->load($this->id);
     }
 
-    #[Bench\Revs(20)]
+    #[Bench\Revs(10)]
     public function benchSave10000Events(): void
     {
         $profile = Profile::create(ProfileId::v7(), 'Peter');

diff --git a/tests/Integration/DbalManager.php → tests/DbalManager.php b/tests/Integration/DbalManager.php → tests/DbalManager.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Patchlevel\EventSourcing\Tests\Integration;
+namespace Patchlevel\EventSourcing\Tests;
 
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Driver\AbstractSQLiteDriver;

diff --git a/tests/Integration/BankAccountSplitStream/IntegrationTest.php b/tests/Integration/BankAccountSplitStream/IntegrationTest.php
@@ -17,12 +17,12 @@
 use Patchlevel\EventSourcing\Schema\DoctrineSchemaDirector;
 use Patchlevel\EventSourcing\Serializer\DefaultEventSerializer;
 use Patchlevel\EventSourcing\Store\DoctrineDbalStore;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use Patchlevel\EventSourcing\Tests\Integration\BankAccountSplitStream\Aggregate\BankAccount;
 use Patchlevel\EventSourcing\Tests\Integration\BankAccountSplitStream\Events\BalanceAdded;
 use Patchlevel\EventSourcing\Tests\Integration\BankAccountSplitStream\Events\BankAccountCreated;
 use Patchlevel\EventSourcing\Tests\Integration\BankAccountSplitStream\Events\MonthPassed;
 use Patchlevel\EventSourcing\Tests\Integration\BankAccountSplitStream\Projection\BankAccountProjector;
-use Patchlevel\EventSourcing\Tests\Integration\DbalManager;
 use PHPUnit\Framework\TestCase;
 
 use function count;

diff --git a/tests/Integration/BasicImplementation/BasicIntegrationTest.php b/tests/Integration/BasicImplementation/BasicIntegrationTest.php
@@ -16,11 +16,11 @@
 use Patchlevel\EventSourcing\Snapshot\Adapter\InMemorySnapshotAdapter;
 use Patchlevel\EventSourcing\Snapshot\DefaultSnapshotStore;
 use Patchlevel\EventSourcing\Store\DoctrineDbalStore;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use Patchlevel\EventSourcing\Tests\Integration\BasicImplementation\Aggregate\Profile;
 use Patchlevel\EventSourcing\Tests\Integration\BasicImplementation\MessageDecorator\FooMessageDecorator;
 use Patchlevel\EventSourcing\Tests\Integration\BasicImplementation\Processor\SendEmailProcessor;
 use Patchlevel\EventSourcing\Tests\Integration\BasicImplementation\Projection\ProfileProjector;
-use Patchlevel\EventSourcing\Tests\Integration\DbalManager;
 use PHPUnit\Framework\TestCase;
 
 /** @coversNothing */

diff --git a/tests/Integration/Outbox/OutboxTest.php b/tests/Integration/Outbox/OutboxTest.php
@@ -16,7 +16,7 @@
 use Patchlevel\EventSourcing\Schema\DoctrineSchemaDirector;
 use Patchlevel\EventSourcing\Serializer\DefaultEventSerializer;
 use Patchlevel\EventSourcing\Store\DoctrineDbalStore;
-use Patchlevel\EventSourcing\Tests\Integration\DbalManager;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use Patchlevel\EventSourcing\Tests\Integration\Outbox\Aggregate\Profile;
 use Patchlevel\EventSourcing\Tests\Integration\Outbox\Events\ProfileCreated;
 use Patchlevel\EventSourcing\Tests\Integration\Outbox\Processor\SendEmailProcessor;

diff --git a/tests/Integration/Pipeline/PipelineChangeStoreTest.php b/tests/Integration/Pipeline/PipelineChangeStoreTest.php
@@ -16,7 +16,7 @@
 use Patchlevel\EventSourcing\Schema\DoctrineSchemaDirector;
 use Patchlevel\EventSourcing\Serializer\DefaultEventSerializer;
 use Patchlevel\EventSourcing\Store\DoctrineDbalStore;
-use Patchlevel\EventSourcing\Tests\Integration\DbalManager;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use Patchlevel\EventSourcing\Tests\Integration\Pipeline\Aggregate\Profile;
 use Patchlevel\EventSourcing\Tests\Integration\Pipeline\Events\NewVisited;
 use Patchlevel\EventSourcing\Tests\Integration\Pipeline\Events\OldVisited;

diff --git a/tests/Integration/Projectionist/ProjectionistTest.php b/tests/Integration/Projectionist/ProjectionistTest.php
@@ -21,7 +21,7 @@
 use Patchlevel\EventSourcing\Schema\DoctrineSchemaDirector;
 use Patchlevel\EventSourcing\Serializer\DefaultEventSerializer;
 use Patchlevel\EventSourcing\Store\DoctrineDbalStore;
-use Patchlevel\EventSourcing\Tests\Integration\DbalManager;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use Patchlevel\EventSourcing\Tests\Integration\Projectionist\Aggregate\Profile;
 use Patchlevel\EventSourcing\Tests\Integration\Projectionist\Projection\ErrorProducerProjector;
 use Patchlevel\EventSourcing\Tests\Integration\Projectionist\Projection\ProfileProjector;

diff --git a/tests/Integration/Store/StoreTest.php b/tests/Integration/Store/StoreTest.php
@@ -11,7 +11,7 @@
 use Patchlevel\EventSourcing\Serializer\DefaultEventSerializer;
 use Patchlevel\EventSourcing\Store\DoctrineDbalStore;
 use Patchlevel\EventSourcing\Store\Store;
-use Patchlevel\EventSourcing\Tests\Integration\DbalManager;
+use Patchlevel\EventSourcing\Tests\DbalManager;
 use Patchlevel\EventSourcing\Tests\Integration\Store\Events\ProfileCreated;
 use PHPUnit\Framework\TestCase;