fix benchmarks

patchlevel · Dec 15, 2023 · df4d467 · df4d467
1 parent a440d0b
commit df4d467
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 14 deletions.
diff --git a/src/Aggregate/AggregateRootAttributeBehaviour.php b/src/Aggregate/AggregateRootAttributeBehaviour.php
@@ -15,7 +15,7 @@ trait AggregateRootAttributeBehaviour
     use AggregateRootMetadataAwareBehaviour;
 
     #[Ignore]
-    private AggregateRootId|null $_aggregateRootId = null;
+    private AggregateRootId|null $cachedAggregateRootId = null;
 
     protected function apply(object $event): void
     {
@@ -35,8 +35,8 @@ protected function apply(object $event): void
 
     public function aggregateRootId(): AggregateRootId
     {
-        if ($this->_aggregateRootId instanceof AggregateRootId) {
-            return $this->_aggregateRootId;
+        if ($this->cachedAggregateRootId instanceof AggregateRootId) {
+            return $this->cachedAggregateRootId;
         }
 
         $metadata = static::metadata();
@@ -50,6 +50,6 @@ public function aggregateRootId(): AggregateRootId
             throw new AggregateIdNotSupported($this::class, $aggregateId);
         }
 
-        return $this->_aggregateRootId = $aggregateId;
+        return $this->cachedAggregateRootId = $aggregateId;
     }
 }
diff --git a/tests/Benchmark/BasicImplementation/Aggregate/Profile.php b/tests/Benchmark/BasicImplementation/Aggregate/Profile.php
@@ -6,6 +6,7 @@
 
 use Patchlevel\EventSourcing\Aggregate\BasicAggregateRoot;
 use Patchlevel\EventSourcing\Attribute\Aggregate;
+use Patchlevel\EventSourcing\Attribute\AggregateId;
 use Patchlevel\EventSourcing\Attribute\Apply;
 use Patchlevel\EventSourcing\Attribute\Snapshot;
 use Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation\Events\NameChanged;
@@ -18,15 +19,11 @@
 #[Snapshot('default')]
 final class Profile extends BasicAggregateRoot
 {
+    #[AggregateId]
     #[ProfileIdNormalizer]
     private ProfileId $id;
     private string $name;
 
-    public function aggregateRootId(): string
-    {
-        return $this->id->toString();
-    }
-
     public static function create(ProfileId $id, string $name): self
     {
         $self = new self();

diff --git a/tests/Benchmark/BasicImplementation/ProfileId.php b/tests/Benchmark/BasicImplementation/ProfileId.php
@@ -4,9 +4,11 @@
 
 namespace Patchlevel\EventSourcing\Tests\Benchmark\BasicImplementation;
 
+use Patchlevel\EventSourcing\Aggregate\AggregateRootId;
+
 use function uniqid;
 
-final class ProfileId
+final class ProfileId implements AggregateRootId
 {
     private function __construct(
         private string $id,

diff --git a/tests/Benchmark/SimpleSetupBench.php b/tests/Benchmark/SimpleSetupBench.php
@@ -72,7 +72,7 @@ public function setUp(): void
     #[Bench\Revs(20)]
     public function benchLoad10000Events(): void
     {
-        $this->repository->load('1');
+        $this->repository->load(ProfileId::fromString('1'));
     }
 
     #[Bench\Revs(20)]

diff --git a/tests/Benchmark/SnapshotsBench.php b/tests/Benchmark/SnapshotsBench.php
@@ -84,12 +84,12 @@ public function setUp(): void
     public function benchLoad10000EventsMissingSnapshot(): void
     {
         $this->adapter->clear();
-        $this->repository->load('1');
+        $this->repository->load(ProfileId::fromString('1'));
     }
 
     #[Bench\Revs(20)]
     public function benchLoad10000Events(): void
     {
-        $this->repository->load('1');
+        $this->repository->load(ProfileId::fromString('1'));
     }
 }
diff --git a/tests/Benchmark/SplitStreamBench.php b/tests/Benchmark/SplitStreamBench.php
@@ -95,7 +95,7 @@ public function provideData(): void
     #[Bench\BeforeMethods('provideData')]
     public function benchLoad10000Events(): void
     {
-        $this->repository->load('1');
+        $this->repository->load(ProfileId::fromString('1'));
     }
 
     #[Bench\Revs(20)]