CS fix

phpstan-baseline.neon

@@ -131,3 +131,9 @@ parameters:
 			identifier: trait.unused
 			count: 1
 			path: src/Subscription/Subscriber/SubscriberUtil.php
+
+		-
+			message: '#^Trait Patchlevel\\EventSourcing\\Test\\SubscriberUtilities is used zero times and is not analysed\.$#'
+			identifier: trait.unused
+			count: 1
+			path: src/Test/SubscriberUtilities.php

src/Test/AggregateAlreadySet.php

@@ -10,4 +10,4 @@ public function __construct()
     {
         parent::__construct('Aggregate already set. You should only return the aggregate if there is no given present.');
     }
-}
+}

src/Test/AggregateRootTestCase.php

@@ -11,7 +11,6 @@
 use PHPUnit\Framework\Constraint\Exception as ExceptionConstraint;
 use PHPUnit\Framework\Constraint\ExceptionMessageIsOrContains;
 use PHPUnit\Framework\TestCase;
-use RuntimeException;
 use Throwable;
 
 abstract class AggregateRootTestCase extends TestCase
@@ -88,9 +87,11 @@ public function assert(): self
                     throw new NoAggregateCreated();
                 }
 
-                if ($aggregate === null && $return instanceof AggregateRoot) {
-                    $aggregate = $return;
+                if ($aggregate !== null || !($return instanceof AggregateRoot)) {
+                    continue;
                 }
+
+                $aggregate = $return;
             }
         } catch (Throwable $throwable) {
             $this->handleException($throwable);

src/Test/AggregateTestError.php

@@ -8,8 +8,4 @@
 
 abstract class AggregateTestError extends RuntimeException
 {
-    public function __construct(string $message = "", int $code = 0, ?Throwable $previous = null)
-    {
-        parent::__construct($message, $code, $previous);
-    }
-}
+}

src/Test/NoAggregateCreated.php

@@ -10,4 +10,4 @@ public function __construct()
     {
         parent::__construct('No aggregate set and no aggregate returned. Please provide given events or create the aggregate with the first action.');
     }
-}
+}

src/Test/SubscriberUtilities.php

@@ -30,9 +30,11 @@ public function executeSetup(object ...$subscribers): self
         foreach ($subscriberAccessors as $subscriberAccessor) {
             $setupMethod = $subscriberAccessor->setupMethod();
 
-            if ($setupMethod) {
-                $setupMethod();
+            if (!$setupMethod) {
+                continue;
             }
+
+            $setupMethod();
         }
 
         return $this;
@@ -60,9 +62,11 @@ public function executeTeardown(object ...$subscribers): self
         foreach ($subscriberAccessors as $subscriberAccessor) {
             $teardownMethod = $subscriberAccessor->teardownMethod();
 
-            if ($teardownMethod) {
-                $teardownMethod();
+            if (!$teardownMethod) {
+                continue;
             }
+
+            $teardownMethod();
         }
 
         return $this;
@@ -77,6 +81,7 @@ public function reset(): void
 
     /**
      * @param array<object> $subscribers
+     *
      * @return iterable<MetadataSubscriberAccessor>
      */
     private function createSubscriberAccessors(array $subscribers): iterable

tests/Unit/Test/AggregateRootTestCaseTest.php

@@ -250,7 +250,7 @@ public function testWithDataProvider(array $givenEvents, array $whens, array $ex
 
     public function getTester(): AggregateRootTestCase
     {
-        return new class($this->name()) extends AggregateRootTestCase {
+        return new class ($this->name()) extends AggregateRootTestCase {
             protected function aggregateClass(): string
             {
                 return Profile::class;

tests/Unit/Test/SubscriberUtilitiesTest.php

@@ -18,7 +18,8 @@ final class SubscriberUtilitiesTest extends TestCase
 {
     public function testRun(): void
     {
-        $subscriber = new #[Projector('test')] class {
+        $subscriber = new #[Projector('test')]
+        class {
             public int $called = 0;
 
             #[Subscribe(ProfileCreated::class)]
@@ -40,9 +41,11 @@ public function run(): void
 
         self::assertSame(1, $subscriber->called);
     }
+
     public function testRunNotFound(): void
     {
-        $subscriber = new #[Projector('test')] class {
+        $subscriber = new #[Projector('test')]
+        class {
             public int $called = 0;
 
             public function run(): void
@@ -66,7 +69,8 @@ public function run(): void
 
     public function testSetup(): void
     {
-        $subscriber = new #[Projector('test')] class {
+        $subscriber = new #[Projector('test')]
+        class {
             public int $called = 0;
 
             #[Setup]
@@ -84,7 +88,8 @@ public function run(): void
 
     public function testSetupNotFound(): void
     {
-        $subscriber = new #[Projector('test')] class {
+        $subscriber = new #[Projector('test')]
+        class {
             public int $called = 0;
 
             public function run(): void
@@ -101,7 +106,8 @@ public function run(): void
 
     public function testTeardown(): void
     {
-        $subscriber = new #[Projector('test')] class {
+        $subscriber = new #[Projector('test')]
+        class {
             public int $called = 0;
 
             #[Teardown]
@@ -119,7 +125,8 @@ public function run(): void
 
     public function testTeardownNotFound(): void
     {
-        $subscriber = new #[Projector('test')] class {
+        $subscriber = new #[Projector('test')]
+        class {
             public int $called = 0;
 
             public function run(): void
@@ -136,7 +143,7 @@ public function run(): void
 
     public function getTester(): TestCase
     {
-        return new class($this->name()) extends TestCase {
+        return new class ($this->name()) extends TestCase {
             use SubscriberUtilities;
         };
     }