add more tests

deptrac.yaml

@@ -17,6 +17,10 @@ deptrac:
       collectors:
         - type: directory
           value: src/Clock/.*
+    - name: CommandBus
+      collectors:
+        - type: directory
+          value: src/CommandBus/.*
     - name: Console
       collectors:
         - type: directory
@@ -102,7 +106,12 @@ deptrac:
       - Attribute
       - MetadataAggregate
     Attribute:
+      - Aggregate
     Clock:
+    CommandBus:
+      - Aggregate
+      - Attribute
+      - Repository
     Console:
       - Aggregate
       - Message

src/CommandBus/AggregateHandlerProvider.php

@@ -72,7 +72,10 @@ private function aggregateClass(string $commandClass): string
         return $handledBy->aggregateClass;
     }
 
-    private function handleClass(Handle $handle, ReflectionMethod $reflectionMethod): string|null
+    /**
+     * @return class-string
+     */
+    private function handleClass(Handle $handle, ReflectionMethod $reflectionMethod): string
     {
         $parameters = $reflectionMethod->getParameters();
 
@@ -93,7 +96,7 @@ private function handleClass(Handle $handle, ReflectionMethod $reflectionMethod)
             return $type->getName();
         }
 
-        throw InvalidHandleMethod::noType(
+        throw InvalidHandleMethod::incompatibleType(
             $reflectionMethod->getDeclaringClass()->getName(),
             $reflectionMethod->getName(),
         );

src/CommandBus/InvalidHandleMethod.php

@@ -15,7 +15,7 @@ public static function noParameters(string $aggregateClass, string $method): sel
         return new self(sprintf('Method "%s" in aggregate "%s" has no parameters', $method, $aggregateClass));
     }
 
-    public static function noType(string $aggregateClass, string $method): self
+    public static function incompatibleType(string $aggregateClass, string $method): self
     {
         return new self(sprintf('Method "%s" in aggregate "%s" has no compatible type', $method, $aggregateClass));
     }

tests/Unit/CommandBus/AggregateHandlerProviderTest.php

@@ -18,7 +18,7 @@
 use stdClass;
 
 /** @covers \Patchlevel\EventSourcing\CommandBus\AggregateHandlerProvider */
-class AggregateHandlerProviderTest extends TestCase
+final class AggregateHandlerProviderTest extends TestCase
 {
     use ProphecyTrait;
 

tests/Unit/CommandBus/DefaultCommandBusTest.php

@@ -12,7 +12,7 @@
 use Prophecy\PhpUnit\ProphecyTrait;
 
 /** @covers \Patchlevel\EventSourcing\CommandBus\DefaultCommandBus */
-class DefaultCommandBusTest extends TestCase
+final class DefaultCommandBusTest extends TestCase
 {
     use ProphecyTrait;
 

tests/Unit/CommandBus/Handler/DefaultHandlerFactoryTest.php

@@ -0,0 +1,55 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Patchlevel\EventSourcing\Tests\Unit\CommandBus\Handler;
+
+use Patchlevel\EventSourcing\CommandBus\Handler\CreateAggregateHandler;
+use Patchlevel\EventSourcing\CommandBus\Handler\DefaultHandlerFactory;
+use Patchlevel\EventSourcing\CommandBus\Handler\UpdateAggregateHandler;
+use Patchlevel\EventSourcing\Repository\RepositoryManager;
+use PHPUnit\Framework\TestCase;
+use Prophecy\PhpUnit\ProphecyTrait;
+use Psr\Container\ContainerInterface;
+
+/** @covers \Patchlevel\EventSourcing\CommandBus\Handler\DefaultHandlerFactory */
+final class DefaultHandlerFactoryTest extends TestCase
+{
+    use ProphecyTrait;
+
+    public function testCreateHandler(): void
+    {
+        $repositoryManager = $this->prophesize(RepositoryManager::class);
+        $container = $this->prophesize(ContainerInterface::class);
+
+        $handlerFactory = new DefaultHandlerFactory(
+            $repositoryManager->reveal(),
+            $container->reveal(),
+        );
+
+        $handler = $handlerFactory->createHandler(
+            'aggregateClass',
+            'method',
+        );
+
+        $this->assertInstanceOf(CreateAggregateHandler::class, $handler);
+    }
+
+    public function testUpdateHandler(): void
+    {
+        $repositoryManager = $this->prophesize(RepositoryManager::class);
+        $container = $this->prophesize(ContainerInterface::class);
+
+        $handlerFactory = new DefaultHandlerFactory(
+            $repositoryManager->reveal(),
+            $container->reveal(),
+        );
+
+        $handler = $handlerFactory->updateHandler(
+            'aggregateClass',
+            'method',
+        );
+
+        $this->assertInstanceOf(UpdateAggregateHandler::class, $handler);
+    }
+}

tests/Unit/CommandBus/HandlerDescriptorTest.php

@@ -0,0 +1,59 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Patchlevel\EventSourcing\Tests\Unit\CommandBus;
+
+use Patchlevel\EventSourcing\CommandBus\HandlerDescriptor;
+use Patchlevel\EventSourcing\Tests\Unit\Fixture\ProfileWithHandlers;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\TestCase;
+
+/** @covers \Patchlevel\EventSourcing\CommandBus\HandlerDescriptor */
+final class HandlerDescriptorTest extends TestCase
+{
+    public function testObjectMethod(): void
+    {
+        $aggregate = ProfileWithHandlers::createEmpty();
+
+        $descriptor = new HandlerDescriptor($aggregate->changeName(...));
+
+        self::assertEquals($aggregate->changeName(...), $descriptor->callable());
+        self::assertEquals('Patchlevel\EventSourcing\Tests\Unit\Fixture\ProfileWithHandlers::changeName', $descriptor->name());
+    }
+
+    public function testStaticObjectMethod(): void
+    {
+        $descriptor = new HandlerDescriptor([ProfileWithHandlers::class, 'create']);
+
+        self::assertEquals(ProfileWithHandlers::create(...), $descriptor->callable());
+        self::assertEquals('Patchlevel\EventSourcing\Tests\Unit\Fixture\ProfileWithHandlers::create', $descriptor->name());
+    }
+
+    #[RequiresPhp('>= 8.2')]
+    public function testAnonymousFunction(): void
+    {
+        $handler = static function (): void {
+        };
+
+        $descriptor = new HandlerDescriptor($handler(...));
+
+        self::assertEquals($handler(...), $descriptor->callable());
+        self::assertEquals('Closure', $descriptor->name());
+    }
+
+    public function testAnonymousClass(): void
+    {
+        $handler = new class {
+            public function __invoke(): void
+            {
+            }
+        };
+
+        $descriptor = new HandlerDescriptor($handler->__invoke(...));
+
+        self::assertEquals($handler->__invoke(...), $descriptor->callable());
+        self::assertStringContainsString('class@anonymous', $descriptor->name());
+        self::assertStringContainsString(__FILE__, $descriptor->name());
+    }
+}

tests/Unit/CommandBus/ServiceLocatorTest.php

@@ -11,7 +11,7 @@
 use Psr\Clock\ClockInterface;
 
 /** @covers \Patchlevel\EventSourcing\CommandBus\ServiceLocator */
-class ServiceLocatorTest extends TestCase
+final class ServiceLocatorTest extends TestCase
 {
     public function testGetService(): void
     {

tests/Unit/Fixture/ChangeProfileName.php

@@ -8,7 +8,7 @@
 use Patchlevel\EventSourcing\Attribute\Id;
 
 #[HandledBy(ProfileWithHandlers::class)]
-class ChangeProfileName
+final class ChangeProfileName
 {
     public function __construct(
         #[Id]

tests/Unit/Fixture/NoParameterCommand.php

@@ -7,6 +7,6 @@
 use Patchlevel\EventSourcing\Attribute\HandledBy;
 
 #[HandledBy(ProfileWithHandlers::class)]
-class NoParameterCommand
+final class NoParameterCommand
 {
 }

tests/Unit/Fixture/NoTypeCommand.php

@@ -7,6 +7,6 @@
 use Patchlevel\EventSourcing\Attribute\HandledBy;
 
 #[HandledBy(ProfileWithHandlers::class)]
-class NoTypeCommand
+final class NoTypeCommand
 {
 }

tests/Unit/Fixture/ProfileWithHandlers.php

@@ -16,8 +16,14 @@ final class ProfileWithHandlers extends BasicAggregateRoot
     private ProfileId $id;
 
     #[Handle]
-    public static function create(CreateProfile $command): void
+    public static function create(CreateProfile $command): self
     {
+        return new self();
+    }
+
+    public static function createEmpty(): self
+    {
+        return new self();
     }
 
     #[Handle]