Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add additional callbacks #633

Merged
merged 7 commits into from
Jan 8, 2025
Merged

[Feature] Add additional callbacks #633

merged 7 commits into from
Jan 8, 2025

Conversation

mlahariya
Copy link
Collaborator

@mlahariya mlahariya commented Dec 16, 2024

Resolves #630

Adding additional callbacks.

  • learning rate schedulers
  • early stopping
  • gradient monitering

Additionally, writer.write method is modified to reflect more appropriate arguments.

@mlahariya mlahariya self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 95.30201% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.62%. Comparing base (1821399) to head (eca954e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
qadence/ml_tools/trainer.py 78.94% 3 Missing and 1 partial ⚠️
qadence/ml_tools/callbacks/callback.py 95.23% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   85.53%   85.62%   +0.08%     
==========================================
  Files         194      194              
  Lines       16644    16769     +125     
  Branches     1410     1420      +10     
==========================================
+ Hits        14237    14358     +121     
- Misses       2007     2008       +1     
- Partials      400      403       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chMoussa chMoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlahariya mlahariya merged commit 5a7f922 into main Jan 8, 2025
10 checks passed
@mlahariya mlahariya deleted the ML_16122024 branch January 8, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Additional callbacks for ml_tools
2 participants