-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Projector blocks #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Roland-djee! Looks good so far, not much to say :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Roland-djee. One thing to note is that @vytautas-a mentioned he had some issues with GPSR in his addressing pattern MR due to N
not having a defined generator
and generator_eigenvalues
, whereas (I-Z)/2
was fine because each of those separately do have them. Maybe @vytautas-a you can take a look here to see if you think any of these changes might lead to more of those issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but looks overall good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just check it does not generate issues with GPSR as mentioned.
i guess this MR is dependent on pasqal-io/pyqtorch#131 @Roland-djee, should we wrap up that one first |
Indeed. I was waiting for the PyQ one to be merged and a new release before moving forward this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks, lets merge
Closes #193.
Few points to consider:
N
as a projectorN
in controlled blocks, i.e. Toffoli.