-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to pretty-printing for AND/OR/CASE #482
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
+ Coverage 80.98% 81.00% +0.02%
==========================================
Files 68 68
Lines 18680 18704 +24
Branches 18680 18704 +24
==========================================
+ Hits 15128 15152 +24
- Misses 3109 3110 +1
+ Partials 443 442 -1 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (2da9cdb) but now fail: 0 Number failing in Base (2da9cdb) but now pass: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM—with one suggestion to remove the lines that are commented out.
dbb6811
to
63b0023
Compare
519d540
to
6b546aa
Compare
Addresses parts of #473 :
CASE
Also:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.