Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to pretty-printing for AND/OR/CASE #482

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Jul 31, 2024

Addresses parts of #473 :

  • Improves pretty-printing of CASE
  • adds round-trip testing for pretty-printing

Also:

  • Improves pretty-printing of AND/OR connectives
  • Improves pretty-printing of query clauses

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested a review from am357 July 31, 2024 00:28
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (2da9cdb) to head (6b546aa).

Files Patch % Lines
partiql-ast/src/pretty.rs 98.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   80.98%   81.00%   +0.02%     
==========================================
  Files          68       68              
  Lines       18680    18704      +24     
  Branches    18680    18704      +24     
==========================================
+ Hits        15128    15152      +24     
- Misses       3109     3110       +1     
+ Partials      443      442       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 31, 2024

Conformance comparison report

Base (2da9cdb) 933ef51 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (2da9cdb) but now fail: 0

Number failing in Base (2da9cdb) but now pass: 0

Copy link
Contributor

@am357 am357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM—with one suggestion to remove the lines that are commented out.

partiql-ast/src/pretty.rs Outdated Show resolved Hide resolved
@jpschorr jpschorr requested a review from am357 July 31, 2024 17:40
partiql-ast/src/pretty.rs Outdated Show resolved Hide resolved
@jpschorr jpschorr force-pushed the feat-ast-pp-improvements branch from dbb6811 to 63b0023 Compare July 31, 2024 19:14
@jpschorr jpschorr force-pushed the feat-ast-pp-improvements branch from 519d540 to 6b546aa Compare July 31, 2024 19:29
@jpschorr jpschorr requested a review from am357 July 31, 2024 19:31
@jpschorr jpschorr merged commit 6dc088c into main Jul 31, 2024
19 checks passed
@jpschorr jpschorr deleted the feat-ast-pp-improvements branch July 31, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants