Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logical eval ops w/ MISSING arg #457

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

alancai98
Copy link
Member

#456

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (17886f3) to head (e5a1838).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   79.38%   80.70%   +1.32%     
==========================================
  Files          67       66       -1     
  Lines       17912    17638     -274     
  Branches    17912    17638     -274     
==========================================
+ Hits        14219    14235      +16     
+ Misses       3118     2964     -154     
+ Partials      575      439     -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Conformance comparison report

Base (17886f3) 84ce8cf +/-
% Passing 90.35% 90.34% -0.02%
✅ Passing 5731 5730 -1
❌ Failing 612 613 1
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5730

Number failing in both: 612

Number passing in Base (17886f3) but now fail: 1

Number failing in Base (17886f3) but now pass: 0

⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • partiql_tests::eval::spec_tests::section_7::permissive_data_type_mismatch_in_logical_expression

@alancai98 alancai98 marked this pull request as draft March 22, 2024 22:05
@alancai98
Copy link
Member Author

TODO: figure out the permissive behavior of logical operands with mistyped arguments. Should they return MISSING or NULL:

  • NOT { 'a': 1 }
  • TRUE AND {'a': 1}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant