-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1] Add v1 ast -> plan conversion; hook up w/ existing code #1631
Conversation
CROSS-ENGINE-REPORT ❌
Testing Details
Result Details
Now FAILING Tests ❌The following 3 test(s) were previously PASSING in BASE but are now FAILING in TARGET: Click here to see
Now IGNORED Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests180 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-4327469). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-REPORT ✅
Testing DetailsResult Details
|
3688156
to
cf6a2fa
Compare
cae601d
to
46eb17f
Compare
6022e09
to
bf1077a
Compare
bf1077a
to
15b8acc
Compare
partiql-parser/src/main/kotlin/org/partiql/parser/internal/V1PartiQLParserDefault.kt
Show resolved
Hide resolved
23c1a3c
to
1bb9b21
Compare
15b8acc
to
1eeed47
Compare
1eeed47
to
860c7c6
Compare
partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/V1RelConverter.kt
Show resolved
Hide resolved
DataType.NULL -> call("is_null", arg0) | ||
DataType.MISSING -> call("is_missing", arg0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I didn't catch from before. ExprIsType
should be distinct from ExprIsNull
and ExprIsMissing
and ExprIsUnknown
. DataType shouldn't contain the NULL
and MISSING
variants.
That way, you don't need those checks in the visitExprCast
. Since this modelling is not the main topic of this PR, this can be a follow-up if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, @RCHowell gave me some context. The previous sprout AST modeling for IS
and type
were not correct, hence why the current v1 AST modeling is not correct. The correct modeling of IS
in the ast and plan will need some additional spec work so will be addressed in a future PR before v1 is released. I've added some TODOs in data type and ExprIsType
for now.
Relevant Issues
Description
Other Information
Updated Unreleased Section in CHANGELOG: [NO]
Any backward-incompatible changes? [YES]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.