Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Add v1 ast -> plan conversion; hook up w/ existing code #1631

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

alancai98
Copy link
Member

@alancai98 alancai98 commented Oct 25, 2024

Relevant Issues

Description

  • Adds v1 AST -> plan conversion and hooks up w/ existing planner and eval code

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No, on v1
  • Any backward-incompatible changes? [YES]

    • Yes, but on v1
  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

CROSS-ENGINE-REPORT ❌

BASE (LEGACY-V0.14.8) TARGET (EVAL-4327469) +/-
% Passing 89.67% 94.39% 4.72% ✅
Passing 5287 5565 278 ✅
Failing 609 50 -559 ✅
Ignored 0 281 281 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: v0.14.8
  • Base Engine: LEGACY
  • Target Commit: 4327469
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 2643
  • Failing in both: 17
  • Ignored in both: 0
  • PASSING in BASE but now FAILING in TARGET: 3
  • PASSING in BASE but now IGNORED in TARGET: 108
  • FAILING in BASE but now PASSING in TARGET: 180
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The following 3 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. undefinedUnqualifiedVariableWithUndefinedVariableBehaviorMissing, compileOption: PERMISSIVE
  2. undefinedUnqualifiedVariableIsNullExprWithUndefinedVariableBehaviorMissing, compileOption: PERMISSIVE
  3. undefinedUnqualifiedVariableIsMissingExprWithUndefinedVariableBehaviorMissing, compileOption: PERMISSIVE

Now IGNORED Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

180 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-4327469). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-REPORT ✅

BASE (EVAL-47DE56F) TARGET (EVAL-4327469) +/-
% Passing 94.39% 94.39% 0.00% ✅
Passing 5565 5565 0 ✅
Failing 50 50 0 ✅
Ignored 281 281 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 47de56f
  • Base Engine: EVAL
  • Target Commit: 4327469
  • Target Engine: EVAL

Result Details

  • Passing in both: 5565
  • Failing in both: 50
  • Ignored in both: 281
  • PASSING in BASE but now FAILING in TARGET: 0
  • PASSING in BASE but now IGNORED in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0
  • IGNORED in BASE but now PASSING in TARGET: 0

@alancai98 alancai98 force-pushed the v1-migrate-ast-astvisitor branch from 3688156 to cf6a2fa Compare October 28, 2024 17:58
@alancai98 alancai98 force-pushed the v1-migrate-ast-ast2plan branch from cae601d to 46eb17f Compare October 28, 2024 17:58
@alancai98 alancai98 changed the base branch from v1-migrate-ast-astvisitor to v1 October 30, 2024 02:04
@alancai98 alancai98 force-pushed the v1-migrate-ast-ast2plan branch from 6022e09 to bf1077a Compare October 30, 2024 02:12
@alancai98 alancai98 changed the title [v1][wip - tests failing] Add v1 ast -> plan conversion; hook up w/ existing code [v1][wip] Add v1 ast -> plan conversion; hook up w/ existing code Oct 30, 2024
@alancai98 alancai98 force-pushed the v1-migrate-ast-ast2plan branch from bf1077a to 15b8acc Compare October 30, 2024 23:02
@alancai98 alancai98 marked this pull request as ready for review October 30, 2024 23:03
@alancai98 alancai98 changed the title [v1][wip] Add v1 ast -> plan conversion; hook up w/ existing code [v1] Add v1 ast -> plan conversion; hook up w/ existing code Oct 30, 2024
@alancai98 alancai98 changed the base branch from v1 to v1-migrate-ast-astvisitor October 30, 2024 23:14
@alancai98 alancai98 requested a review from RCHowell October 30, 2024 23:23
@alancai98 alancai98 force-pushed the v1-migrate-ast-astvisitor branch from 23c1a3c to 1bb9b21 Compare October 31, 2024 18:38
@alancai98 alancai98 force-pushed the v1-migrate-ast-ast2plan branch from 15b8acc to 1eeed47 Compare October 31, 2024 18:41
@alancai98 alancai98 requested a review from johnedquinn October 31, 2024 18:42
Base automatically changed from v1-migrate-ast-astvisitor to v1 October 31, 2024 22:38
@alancai98 alancai98 force-pushed the v1-migrate-ast-ast2plan branch from 1eeed47 to 860c7c6 Compare October 31, 2024 22:43
Comment on lines +734 to +735
DataType.NULL -> call("is_null", arg0)
DataType.MISSING -> call("is_missing", arg0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I didn't catch from before. ExprIsType should be distinct from ExprIsNull and ExprIsMissing and ExprIsUnknown. DataType shouldn't contain the NULL and MISSING variants.
That way, you don't need those checks in the visitExprCast. Since this modelling is not the main topic of this PR, this can be a follow-up if you'd like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, @RCHowell gave me some context. The previous sprout AST modeling for IS and type were not correct, hence why the current v1 AST modeling is not correct. The correct modeling of IS in the ast and plan will need some additional spec work so will be addressed in a future PR before v1 is released. I've added some TODOs in data type and ExprIsType for now.

@alancai98 alancai98 requested a review from johnedquinn October 31, 2024 23:00
@alancai98 alancai98 merged commit 6e7d560 into v1 Oct 31, 2024
14 checks passed
@alancai98 alancai98 deleted the v1-migrate-ast-ast2plan branch October 31, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants