Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Add name method to AstEnum #1630

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[v1] Add name method to AstEnum #1630

merged 1 commit into from
Oct 28, 2024

Conversation

alancai98
Copy link
Member

Relevant Issues

Description

  • Adds a .name method to every AstEnum. This is part of normal enum classes but was missing from our AstEnum abstract class definition.
  • Some other minor AstEnum implementation fixes

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No, on v1
  • Any backward-incompatible changes? [No]

  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 requested a review from RCHowell October 25, 2024 21:20
@alancai98 alancai98 self-assigned this Oct 25, 2024
default: return "UNKNOWN";
}
}

@NotNull
private static final int[] codes = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(self-review): I re-arranged the values in this PR to align with the order of the data type constants defined above https://github.com/partiql/partiql-lang-kotlin/blob/v1-migrate-ast/partiql-ast/src/main/java/org/partiql/ast/v1/DataType.java#L12-L71.

Comment on lines -14 to -17
private static final int UNKNOWN = 0;
private static final int UNION = 1;
private static final int INTERSECT = 2;
private static final int EXCEPT = 3;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(self-review) these were inadvertently private

Comment on lines -18 to -19
public static final int LAG = 0;
public static final int LEAD = 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(self-review) these enum variants were inadvertently all 0. Adding the name method to AstEnum allowed us to catch this bug.

Copy link

CROSS-ENGINE-REPORT ❌

BASE (LEGACY-V0.14.8) TARGET (EVAL-7CF93FD) +/-
% Passing 89.67% 94.39% 4.72% ✅
Passing 5287 5565 278 ✅
Failing 609 50 -559 ✅
Ignored 0 281 281 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: v0.14.8
  • Base Engine: LEGACY
  • Target Commit: 7cf93fd
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 2643
  • Failing in both: 17
  • Ignored in both: 0
  • PASSING in BASE but now FAILING in TARGET: 3
  • PASSING in BASE but now IGNORED in TARGET: 108
  • FAILING in BASE but now PASSING in TARGET: 180
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The following 3 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. undefinedUnqualifiedVariableWithUndefinedVariableBehaviorMissing, compileOption: PERMISSIVE
  2. undefinedUnqualifiedVariableIsNullExprWithUndefinedVariableBehaviorMissing, compileOption: PERMISSIVE
  3. undefinedUnqualifiedVariableIsMissingExprWithUndefinedVariableBehaviorMissing, compileOption: PERMISSIVE

Now IGNORED Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

180 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-7CF93FD). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-REPORT ✅

BASE (EVAL-7F382DB) TARGET (EVAL-7CF93FD) +/-
% Passing 94.39% 94.39% 0.00% ✅
Passing 5565 5565 0 ✅
Failing 50 50 0 ✅
Ignored 281 281 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 7f382db
  • Base Engine: EVAL
  • Target Commit: 7cf93fd
  • Target Engine: EVAL

Result Details

  • Passing in both: 5565
  • Failing in both: 50
  • Ignored in both: 281
  • PASSING in BASE but now FAILING in TARGET: 0
  • PASSING in BASE but now IGNORED in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0
  • IGNORED in BASE but now PASSING in TARGET: 0

@alancai98 alancai98 merged commit 246b63c into v1 Oct 28, 2024
14 checks passed
@alancai98 alancai98 deleted the v1-migrate-ast branch October 28, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants