Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Add Lombok Builders to classes; make every field final #1616

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

alancai98
Copy link
Member

@alancai98 alancai98 commented Oct 8, 2024

Relevant Issues

Description

  • Add Lombok builders to classes
  • Makes every field final

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No, v1
  • Any backward-incompatible changes? [YES]

    • Yes but on v1
  • Any new external dependencies? [YES]

    • Yes, add Lombok Kotlin plugin (to reference Lombok classes/interfaces from Kotlin) and Lombok API dependency
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 changed the title [draft] Add Lombok Builders to classes; make every field final [draft][v1] Add Lombok Builders to classes; make every field final Oct 8, 2024
@alancai98 alancai98 self-assigned this Oct 8, 2024
@alancai98 alancai98 force-pushed the v1-simplify-ast-utils branch 2 times, most recently from 8b13beb to 8a778a9 Compare October 16, 2024 19:29
@alancai98 alancai98 changed the title [draft][v1] Add Lombok Builders to classes; make every field final [v1] Add Lombok Builders to classes; make every field final Oct 16, 2024
@alancai98 alancai98 force-pushed the v1-simplify-ast-utils branch from 8a778a9 to 9b3f074 Compare October 16, 2024 19:36
@partiql partiql deleted a comment from github-actions bot Oct 16, 2024
@partiql partiql deleted a comment from github-actions bot Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

CROSS-ENGINE-REPORT ❌

BASE (LEGACY-V0.14.8) TARGET (EVAL-5994565) +/-
% Passing 89.67% 94.22% 4.55% ✅
Passing 5287 5555 268 ✅
Failing 609 54 -555 ✅
Ignored 0 287 287 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: v0.14.8
  • Base Engine: LEGACY
  • Target Commit: 5994565
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing/Ignored Tests. ❌
  • Passing in both: 2642
  • Failing in both: 18
  • Ignored in both: 0
  • PASSING in BASE but now FAILING in TARGET: 1
  • PASSING in BASE but now IGNORED in TARGET: 111
  • FAILING in BASE but now PASSING in TARGET: 179
  • IGNORED in BASE but now PASSING in TARGET: 0

Now FAILING Tests ❌

The following 1 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. data type mismatch in logical expression, compileOption: PERMISSIVE

Now IGNORED Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

179 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-5994565). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-REPORT ✅

BASE (EVAL-7E43535) TARGET (EVAL-5994565) +/-
% Passing 94.22% 94.22% 0.00% ✅
Passing 5555 5555 0 ✅
Failing 54 54 0 ✅
Ignored 287 287 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 7e43535
  • Base Engine: EVAL
  • Target Commit: 5994565
  • Target Engine: EVAL

Result Details

  • Passing in both: 5555
  • Failing in both: 54
  • Ignored in both: 287
  • PASSING in BASE but now FAILING in TARGET: 0
  • PASSING in BASE but now IGNORED in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0
  • IGNORED in BASE but now PASSING in TARGET: 0

@partiql partiql deleted a comment from github-actions bot Oct 16, 2024
@alancai98
Copy link
Member Author

alancai98 commented Oct 16, 2024

seems like we still are getting a new conformance comparison report for every commit. I'll investigate further

PR to fix -- #1620

@alancai98 alancai98 marked this pull request as ready for review October 16, 2024 19:54
@alancai98 alancai98 force-pushed the v1-simplify-ast-utils branch from 9b3f074 to c581678 Compare October 16, 2024 23:36
@alancai98 alancai98 requested a review from johnedquinn October 16, 2024 23:42
@alancai98 alancai98 merged commit f2897a5 into v1 Oct 16, 2024
14 checks passed
@alancai98 alancai98 deleted the v1-simplify-ast-utils branch October 16, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants