[v1] Make AstNode equals and hashcode abstract; add missing impls

partiql · Dec 10, 2024 · bf15bdb · bf15bdb
1 parent 01ed70a
commit bf15bdb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/partiql-ast/src/main/java/org/partiql/ast/AstNode.java b/partiql-ast/src/main/java/org/partiql/ast/AstNode.java
@@ -17,4 +17,10 @@ public abstract class AstNode {
     public abstract Collection<AstNode> children();
 
     public abstract <R, C> R accept(@NotNull AstVisitor<R, C> visitor, C ctx);
+
+    @Override
+    public abstract int hashCode();
+
+    @Override
+    public abstract boolean equals(Object obj);
 }
diff --git a/partiql-ast/src/main/java/org/partiql/ast/GroupBy.java b/partiql-ast/src/main/java/org/partiql/ast/GroupBy.java
@@ -50,6 +50,7 @@ public <R, C> R accept(@NotNull AstVisitor<R, C> visitor, C ctx) {
      * TODO docs, equals, hashcode
      */
     @lombok.Builder(builderClassName = "Builder")
+    @EqualsAndHashCode(callSuper = false)
     public static class Key extends AstNode {
         @NotNull
         public final Expr expr;

diff --git a/partiql-ast/src/main/java/org/partiql/ast/Let.java b/partiql-ast/src/main/java/org/partiql/ast/Let.java
@@ -37,6 +37,7 @@ public <R, C> R accept(@NotNull AstVisitor<R, C> visitor, C ctx) {
      * TODO docs, equals, hashcode
      */
     @lombok.Builder(builderClassName = "Builder")
+    @EqualsAndHashCode(callSuper = false)
     public static class Binding extends AstNode {
         @NotNull
         public final Expr expr;