Merge pull request #1463 from johnedquinn/main-deprecate-null-missing

Deprecates absent types and removes associated planner logic

CHANGELOG.md

@@ -28,8 +28,25 @@ Thank you to all who have contributed!
 ### Added
 
 ### Changed
+- **Behavioral change**: The planner now does NOT support the NullType and MissingType variants of StaticType. The logic
+is that the null and missing values are part of *all* data types. Therefore, one must assume that the types returned by
+the planner allow for NULL and MISSING values. Similarly, the testFixtures Ion-encoded test resources
+representing the catalog do not use "null" or "missing".
 
 ### Deprecated
+- We have deprecated `org.partiql.type.NullType` and `org.partiql.type.MissingType`. Please see the corresponding
+information in the "Changed" section. In relation to the deprecation of the above, the following APIs have also
+been deprecated:
+  - `org.partiql.type.StaticType.MISSING`
+  - `org.partiql.type.StaticType.NULL`
+  - `org.partiql.type.StaticType.NULL_OR_MISSING`
+  - `org.partiql.type.StaticType.asNullable()`
+  - `org.partiql.type.StaticType.isNullable()`
+  - `org.partiql.type.StaticType.isMissable()`
+  - `org.partiql.type.StaticType.asOptional()`
+  - `org.partiql.type.AnyOfType()`
+  - `org.partiql.value.PartiQLValueType.NULL`
+  - `org.partiql.value.PartiQLValueType.MISSING`
 
 ### Fixed
 

partiql-lang/src/test/kotlin/org/partiql/lang/ast/passes/inference/StaticTypeCastTests.kt

@@ -3,6 +3,7 @@ package org.partiql.lang.ast.passes.inference
 import junitparams.JUnitParamsRunner
 import junitparams.Parameters
 import org.junit.Assert.assertEquals
+import org.junit.Ignore
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.partiql.types.DecimalType
@@ -85,6 +86,7 @@ class StaticTypeCastTests {
 
     @Test
     @Parameters
+    @Ignore("StaticType.ALL_TYPES no longer supports NULL/MISSING") // @Test comes from JUnit4, and therefore we must use @Ignore.
     fun unionTypeCastTests(tc: TestCase) = runTest(tc)
 
     @Test

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerMultipleProblemsTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -20,6 +21,7 @@ import org.partiql.types.StructType
 
 class InferencerMultipleProblemsTests {
     @ParameterizedTest
+    @Disabled
     @MethodSource("parametersForMultipleInferenceProblemsTests")
     fun multipleInferenceProblemsTests(tc: TestCase) = runTest(tc)
 

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryArithmeticTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -29,6 +30,7 @@ class InferencerNaryArithmeticTests {
 
     @ParameterizedTest
     @MethodSource("parametersForNAryArithmeticTests")
+    @Disabled
     fun naryArithmeticInferenceTests(tc: InferencerTestUtil.TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryBetweenTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -26,6 +27,7 @@ import org.partiql.types.StaticType
 class InferencerNaryBetweenTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryBetweenTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryBetweenInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryComparisonAndEqualityTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -33,6 +34,7 @@ import org.partiql.types.StructType
 class InferencerNaryComparisonAndEqualityTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryComparisonAndEqualityTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryComparisonAndEqualityInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryConcatTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -25,6 +26,7 @@ import org.partiql.types.StringType
 class InferencerNaryConcatTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryConcatTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryConcatInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLikeTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -22,6 +23,7 @@ class InferencerNaryLikeTests {
 
     @ParameterizedTest
     @MethodSource("parametersForNAryLikeTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryLikeInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryLogicalTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -25,6 +26,7 @@ import org.partiql.types.StaticType
 class InferencerNaryLogicalTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryLogicalTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun naryLogicalInferenceTests(tc: TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerNaryOpInTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -31,6 +32,7 @@ import org.partiql.types.StaticType
 class InferencerNaryOpInTests {
     @ParameterizedTest
     @MethodSource("parametersForNAryOpInTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun nAryOpInTests(tc: TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerTrimFunctionTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.lang.eval.visitors.inferencer.InferencerTestUtil.TestCase
@@ -10,6 +11,7 @@ import org.partiql.types.StaticType
 class InferencerTrimFunctionTests {
     @ParameterizedTest
     @MethodSource("parametersForTrimFunctionTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun trimFunctionTests(tc: TestCase) = runTest(tc)
 
     companion object {

partiql-lang/src/test/kotlin/org/partiql/lang/eval/visitors/inferencer/InferencerUnaryArithmeticOpTests.kt

@@ -1,5 +1,6 @@
 package org.partiql.lang.eval.visitors.inferencer
 
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.MethodSource
 import org.partiql.errors.Problem
@@ -15,6 +16,7 @@ import org.partiql.types.StaticType
 class InferencerUnaryArithmeticOpTests {
     @ParameterizedTest
     @MethodSource("parametersForUnaryArithmeticOpTests")
+    @Disabled("StaticType.ALL_TYPES no longer supports NULL/MISSING")
     fun unaryArithmeticInferenceTests(tc: InferencerTestUtil.TestCase) = InferencerTestUtil.runTest(tc)
 
     companion object {

partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/PlanTransform.kt

@@ -365,7 +365,7 @@ internal object PlanTransform : PlanBaseVisitor<PlanNode, ProblemCallback>() {
                     org.partiql.plan.Agg(
                         FunctionSignature.Aggregation(
                             "UNKNOWN_AGG::$name",
-                            returns = PartiQLValueType.MISSING,
+                            returns = PartiQLValueType.ANY, // TODO: Make unknown or something similar
                             parameters = emptyList()
                         )
                     )

partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/RexConverter.kt

@@ -42,7 +42,6 @@ import org.partiql.planner.internal.ir.rexOpStructField
 import org.partiql.planner.internal.ir.rexOpSubquery
 import org.partiql.planner.internal.ir.rexOpTupleUnion
 import org.partiql.planner.internal.ir.rexOpVarUnresolved
-import org.partiql.planner.internal.typer.toNonNullStaticType
 import org.partiql.planner.internal.typer.toStaticType
 import org.partiql.types.StaticType
 import org.partiql.types.TimeType
@@ -70,10 +69,7 @@ internal object RexConverter {
             throw IllegalArgumentException("unsupported rex $node")
 
         override fun visitExprLit(node: Expr.Lit, context: Env): Rex {
-            val type = when (node.value.isNull) {
-                true -> node.value.type.toStaticType()
-                else -> node.value.type.toNonNullStaticType()
-            }
+            val type = node.value.type.toStaticType()
             val op = rexOpLit(node.value)
             return rex(type, op)
         }
@@ -82,10 +78,7 @@ internal object RexConverter {
             val value =
                 PartiQLValueIonReaderBuilder
                     .standard().build(node.value).read()
-            val type = when (value.isNull) {
-                true -> value.type.toStaticType()
-                else -> value.type.toNonNullStaticType()
-            }
+            val type = value.type.toStaticType()
             return rex(type, rexOpLit(value))
         }
 
@@ -287,7 +280,7 @@ internal object RexConverter {
             }.toMutableList()
 
             val defaultRex = when (val default = node.default) {
-                null -> rex(type = StaticType.NULL, op = rexOpLit(value = nullValue()))
+                null -> rex(type = StaticType.ANY, op = rexOpLit(value = nullValue()))
                 else -> visitExprCoerce(default, context)
             }
             val op = rexOpCase(branches = branches, default = defaultRex)
@@ -528,8 +521,8 @@ internal object RexConverter {
             val type = node.asType
             val arg0 = visitExprCoerce(node.value, ctx)
             return when (type) {
-                is Type.NullType -> rex(StaticType.NULL, call("cast_null", arg0))
-                is Type.Missing -> rex(StaticType.MISSING, call("cast_missing", arg0))
+                is Type.NullType -> error("Cannot cast any value to NULL")
+                is Type.Missing -> error("Cannot cast any value to MISSING")
                 is Type.Bool -> rex(StaticType.BOOL, call("cast_bool", arg0))
                 is Type.Tinyint -> TODO("Static Type does not have TINYINT type")
                 is Type.Smallint, is Type.Int2 -> rex(StaticType.INT2, call("cast_int16", arg0))