-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_dialect.py
Re-Work, modifier
Argument for LLMQA
, Documentation updates
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is where the 2nd argument to an 'IN' clause shows up, e.g. 'WHERE x IN {{Ingredient()}}'
Else, this will break the `name=value` call to guidance
This allows us to skip the final `query_context.to_string()` call before executing the compiled blendsql query
…rs')}})) to work Single row should be interpreted correctly as options
This was a bad idea; a short-term fix for a bug. Keeping this would cause headaches in the future.
We always need to evaluate an expression if it contains an ingredient. This change was breaking tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_dialect.py
to better handle different SQL dialectsSTRUCT
nodes to do our processingget_dialect()
function to route queries to the correct sqlglot dialect, and interpret all aliased ingredients (i.e.{{A()}}
,{{B()}}
, etc.) as aTokenType.FUNCTION
viaINGREDIENT_TOKEN_TYPE_MAPPING
modifier
argumentLLMQA
now works in a context where a list datatype is required, such asIN
orVALUES
clausesDataType
object in_constants.py
was createdAzurePhiModel
blendsql-by-example.ipynb
Before:
After: