Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Revert "Add-xcm-emulator-and-tests (#304)" #312

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

metricaez
Copy link
Collaborator

This reverts commit e51c1fe.

Decommission emulator es it is generating conflicts in v1.1 with overhead benchmarking and asynchronous backing. Propose to update to v1.1 and forward and test integrations of emulator in more recent versions that might have fixed this issue.
Tests migrations and implementation is still valid so the process of re integrating it would be much faster.

@metricaez
Copy link
Collaborator Author

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Nov 21, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4425634 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-c1a4a576-0581-4f52-b03f-0277dfbc2756 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 21, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4425634 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4425634/artifacts/download.

@metricaez
Copy link
Collaborator Author

@stiiifff I propose we take this path. Even though a new problem appeared.

@stiiifff
Copy link
Contributor

Awesome @metricaez, thanks for tracking this down 🙏️ to the latest addition of the XCM emulator. Indeed, let's finalize the v1.1 upgrade, and add the XCM emulator back at a later point.

@stiiifff stiiifff merged commit c614f39 into main Nov 22, 2023
5 checks passed
@stiiifff stiiifff deleted the revert-emulator-and-prepare-update branch November 22, 2023 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants