feat: coretime implementation #1558
Conversation
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
744895d to
6de3395
Compare
filvecchiato
changed the title
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
4efc743 to
f6e8a77
Compare
filvecchiato
changed the title
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
9ef9d68 to
e8a0808
Compare
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
142039d to
4dcdf17
Compare
| } | ||
|
|
||
| private checkCoretimeModule = (): void => { | ||
| if (this.api.query.onDemandAssignmentProvider && this.api.query.coretimeAssignmentProvider) { |
There was a problem hiding this comment.
So if I understand this correct - either broker needs to exist or onDemandAssignmentProvider and coretimeAssignmentProvider?
Would there ever be a case where they all need to exists at once?
There was a problem hiding this comment.
From my understanding broker is a coretime chain pallet only while onDemandAssignemntProvider and coretimeAssignmentProvider are relay chain only pallets
| CoretimeGenericController.sanitizedSend(res, await this.service.getCoretimeCores(hash)); | ||
| }; | ||
|
|
||
| private checkCoretimeModule = (): void => { |
There was a problem hiding this comment.
Same sentiment as the comment in CoretimeChain
| return coreSchedules as unknown as Record<string, unknown>[]; | ||
| }; | ||
|
|
||
| private getAndDecodeCoreDescriptors = async (api: ApiDecoration<'promise'>): Promise<TCoreDescriptor[]> => { |
There was a problem hiding this comment.
| private getAndDecodeCoreDescriptors = async (api: ApiDecoration<'promise'>): Promise<TCoreDescriptor[]> => { | |
| private getAndDecodeCoreDescriptors = async (api: ApiDecoration<'promise'>): Promise<TCoreDescriptor[]> => { | |
| const coreDescriptors = await api.query.coretimeAssignmentProvider.coreDescriptors.entries(); | |
| return coreDescriptors.map((descriptor) => extractCoreDescriptorInfo(descriptor[0], descriptor[1])); | |
| }; |
There was a problem hiding this comment.
api.query.coretimeAssignmentProvider.coreDescriptors.entries() return a type: [StorageKey, Codec][]
for which i need to typecast to convert the codec into the actual type. I'm not sure if something could be off on my set up, it seems like I don't get the corresponding type correctly and thrown an error
| return descriptors.map((descriptor) => extractCoreDescriptorInfo(descriptor[0], descriptor[1])); | ||
| }; | ||
|
|
||
| private getAndDecodeParachainsLifecycle = async (api: ApiDecoration<'promise'>): Promise<TParaLifecycle[]> => { |
There was a problem hiding this comment.
| private getAndDecodeParachainsLifecycle = async (api: ApiDecoration<'promise'>): Promise<TParaLifecycle[]> => { | |
| private getAndDecodeParachainsLifecycle = async (api: ApiDecoration<'promise'>): Promise<TParaLifecycle[]> => { | |
| const parachains = await api.query.paras.paraLifecycles.entries(); | |
| return parachains.map((para) => | |
| extractParachainLifecycleInfo( | |
| para[0], | |
| para[1], | |
| ), | |
| ); | |
| }; |
There was a problem hiding this comment.
api.query.paras.paraLifecycles.entries() return a type: [StorageKey, Codec][]
for which i need to typecast to convert the codec into the actual type. I'm not sure if something could be off on my set up, it seems like I don't get the corresponding type correctly and thrown an error
I removed most of typecasting (nice catch, not sure I was having issues before), I had to leave typecasting for coreDescriptors and paraLifecycles though, we can doublecheck if there is something wrong on my end though
thanks for checking it out! |
New Feature: Implements the coretime endpoints for relay chain and for coretime chain.
It includes basic endpoints for single information record recovery, and more advanced endpoints with precomputed calculations and information.