Update pallet nomination pool to support Block Number Provider #6715
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
approved these changes
Dec 1, 2024
| @@ -3092,9 +3098,11 @@ pub mod pallet { | |||
| } | |||
|
|
|||
| #[pallet::hooks] | |||
| impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> { | |||
| impl<T: Config> Hooks<frame_system::pallet_prelude::BlockNumberFor<T>> for Pallet<T> { | |||
There was a problem hiding this comment.
personally I would have introduced a different type alias to avoid the name collision with the frame_system::pallet_prelude::BlockNumberFor.
But I don't mind any implementation.
There was a problem hiding this comment.
i have done as suggested
There was a problem hiding this comment.
I was thinking the opposite like keeping BlockNumberFor for the system one, and having maybe ProvidedBlockNumberFor or PalletBlockNumberFor.
But this is also good to me.
gui1117
reviewed
Dec 2, 2024
| doc: | ||
| - audience: Runtime Dev | ||
| description: | | ||
| This PR makes the nomination pool pallet use the relay chain as a block provider for a parachain on a regular schedule. |
There was a problem hiding this comment.
It doesn't force the nomination pool pallet to use the relay chain block provider,
Suggested change
| This PR makes the nomination pool pallet use the relay chain as a block provider for a parachain on a regular schedule. | |
| This PR makes the block number provider used in the nomination pool pallet configurable. Before this PR, nomination pool pallet always used the system block number, with this PR some runtime can opt to use the relay chain block number instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces BlockNumberProvider config for the nomination pool pallet.
closes part of #6297