Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2412] Backport #6465 #6536 #6579 #6649

Open
wants to merge 4 commits into
base: stable2412
Choose a base branch
from
Open

[stable2412] Backport #6465 #6536 #6579 #6649

wants to merge 4 commits into from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Nov 26, 2024 •
edited
Loading

bkontur and others added 3 commits November 26, 2024 13:52
@bkontur
Fixed bridges zombienet tests because of removed NetworkId::Rococo/We…
a7da83f 
…stend from xcm::v5 (#6465)

Closes: #6449
@bkontur @actions-user
Bridges testing improvements (#6536)
c5dbb6f 
This PR includes:  
- Refactored integrity tests to support standalone deployment of
`pallet-bridge-messages`.
- Refactored the `open_and_close_bridge_works` test case to support
multiple scenarios, such as:
  1. A local chain opening a bridge.  
  2. Sibling parachains opening a bridge.  
  3. The relay chain opening a bridge.  
- Previously, we added instance support for `pallet-bridge-relayer` but
overlooked updating the `DeliveryConfirmationPaymentsAdapter`.

---------

Co-authored-by: GitHub Action <[email protected]>
@bkontur
Error logging for send xcm to pallet-xcm (#6579)
b7404da
@bkontur bkontur added T6-XCM This PR/Issue is related to XCM. T15-bridges This PR/Issue is related to bridges. labels Nov 26, 2024
@bkontur bkontur requested a review from a team as a code owner November 26, 2024 13:05
This was referenced Nov 26, 2024
Merged
Merged
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 26, 2024 13:06
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@bkontur @actions-user
xcm: fix local/remote exports when inner routers return `NotApplicabl…
ea413ca 
…e` (#6645)

This PR addresses two small fixes:  

1. Fixed a typo ("as as") found on the way.  
2. Resolved a bug in the `local/remote exporters` used for bridging.
Previously, they consumed `dest` and `msg` without returning them when
inner routers/exporters failed with `NotApplicable`. This PR ensures
compliance with the
[`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450)
and
[`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45)
traits.

---------

Co-authored-by: GitHub Action <[email protected]>
@bkontur bkontur requested a review from a team as a code owner November 26, 2024 16:19
@bkontur bkontur mentioned this pull request Nov 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM. T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkontur @acatangiu