Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omni-node: --dev sets manual seal and allows --chain to be set #6646

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

iulianbarbu
Copy link
Contributor

@iulianbarbu iulianbarbu commented Nov 26, 2024

Description

This PR changes a few things:

  • --dev flag will not conflict with --chain anymore, but if --chain is not given will set --chain=dev.
  • OmniNode --dev-block-time requires --dev too, and that's to enable the assumed development setup that's configured throughout the codebase when --dev is present alongside a manual seal based OmniNode.
  • --dev-block-time is optional and it defaults to 3000ms if not set after setting --dev.
  • to start OmniNode with manual seal it is enough to pass just --dev.

Integration

Relevant for node/runtime developers that use OmniNode lib, including polkadot-omni-node binary, although the recommended way is to use chopsticks.

Review Notes

  • Decided to focus only on OmniNode & templates docs in relation to it, and leave the parachain-template-node as is (meaning --dev still needs a relay chain here). I am doing this because I think we want either way to phase out parachain-template-node and adding support for manual seal for it is wasted effort.
  • Decided to not infer the block time based on AURA config yet because there is still the option of setting a specific block time by using --dev-block-time. Also, would want first to align & merge on runtime metadata checks we added in Omni Node here: omni-node: add metadata checks for runtime/parachain compatibility #6450 before starting to infer AURA config slot duration via the same way.

✔️ update the docs

@iulianbarbu iulianbarbu added T9-cumulus This PR/Issue is related to cumulus. T17-Templates This PR/Issue is related to templates labels Nov 26, 2024
@iulianbarbu iulianbarbu self-assigned this Nov 26, 2024
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
@iulianbarbu iulianbarbu marked this pull request as draft November 26, 2024 10:48
@iulianbarbu iulianbarbu changed the title omni-node: --dev starts manual seal and allows --chain to be set omni-node: --dev sets manual seal and allows --chain to be set Nov 26, 2024
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T9-cumulus This PR/Issue is related to cumulus. T17-Templates This PR/Issue is related to templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant