omni-node: --dev sets manual seal and allows --chain to be set #6646
+44
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a few things:
--dev
flag will not conflict with--chain
anymore, but if--chain
is not given will set--chain=dev
.--dev-block-time
requires--dev
too, and that's to enable the assumed development setup that's configured throughout the codebase when--dev
is present alongside a manual seal based OmniNode.--dev-block-time
is optional and it defaults to 3000ms if not set after setting--dev
.--dev
.Integration
Relevant for node/runtime developers that use OmniNode lib, including
polkadot-omni-node
binary, although the recommended way is to usechopsticks
.Review Notes
parachain-template-node
as is (meaning--dev
still needs a relay chain here). I am doing this because I think we want either way to phase outparachain-template-node
and adding support for manual seal for it is wasted effort.--dev-block-time
. Also, would want first to align & merge on runtime metadata checks we added in Omni Node here: omni-node: add metadata checks for runtime/parachain compatibility #6450 before starting to infer AURA config slot duration via the same way.✔️ update the docs