Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize initialization of networking protocol benchmarks #6636

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AndreiEres
Copy link
Contributor

@AndreiEres AndreiEres commented Nov 25, 2024

Description

These changes should enhance the quality of benchmark results by excluding worker initialization time from the measurements and reducing the overall duration of the benchmarks.

Integration

It should not affect any downstream projects.

Review Notes

  • Workers initialize once per benchmark to avoid side effects.
  • The listen address is assigned when a worker starts.
  • Benchmarks are divided into two groups by size to create better charts for comparison.

@AndreiEres AndreiEres added R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 25, 2024
@AndreiEres AndreiEres marked this pull request as ready for review November 25, 2024 12:31
@AndreiEres
Copy link
Contributor Author

/cmd prdoc --audience node_dev

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12010630549
Failed job name: cargo-clippy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants