Fix `XcmPaymentApi::query_weight_to_asset_fee` version conversion #6459

franciscoaguirre · 2024-11-12T20:11:31Z

The query_weight_to_asset_fee function was trying to convert versions by using try_as, this function doesn't convert from a versioned to a concrete type.
This would cause all calls with a lower version to fail.

The correct function to use is the good old try_into.
Now those calls work :)

franciscoaguirre · 2024-11-12T20:18:01Z

bot fmt

command-bot · 2024-11-12T20:18:06Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7748401 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-7b71fbec-42d5-4285-ae51-a1bb4e834e9f to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-11-12T20:18:48Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7748401 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7748401/artifacts/download.

bkontur

lgmt modulo @franciscoaguirre could you please check #6467 - it could simplify

cumulus/parachains/runtimes/assets/asset-hub-rococo/tests/tests.rs

Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]>

franciscoaguirre · 2024-11-15T19:51:20Z

/cmd fmt

github-actions · 2024-11-15T19:53:12Z

Command "fmt" has started 🚀 See logs here

github-actions · 2024-11-15T19:53:37Z

Command "fmt" has finished ✅ See logs here

franciscoaguirre · 2024-11-15T19:59:39Z

@bkontur I deduplicated the test and extended it to call quote_price_tokens_for_exact_tokens. Please take a look again.

franciscoaguirre · 2024-11-15T20:05:09Z

/cmd help

github-actions · 2024-11-15T20:07:14Z

Command "help" has started 🚀 See logs here

github-actions · 2024-11-15T20:07:28Z

Command "help" has failed ❌! See logs here

franciscoaguirre · 2024-11-15T20:08:10Z

/cmd --help

github-actions · 2024-11-15T20:08:51Z

Command help:

usage: /cmd  [--help] [--quiet] [--clean] [--image IMAGE]
             {bench,fmt,update-ui,prdoc} ...

A command runner for polkadot-sdk repo

positional arguments:
  {bench,fmt,update-ui,prdoc}
                        a command to run
    bench               Runs benchmarks
    fmt                 Formats code (cargo +nightly-VERSION fmt) and configs
                        (taplo format)
    update-ui           Updates UI tests
    prdoc               Generates PR documentation

options:
  --help                help for help if you need some help
  --quiet               Won't print start/end/failed messages in PR
  --clean               Clean up the previous bot's & author's comments in PR
  --image IMAGE         Override docker image '--image
                        docker.io/paritytech/ci-unified:latest'

### Command 'bench'
usage: /cmd bench [-h] [--quiet] [--clean] [--image IMAGE]
                  [--runtime [{dev,westend,rococo,asset-hub-westend,asset-hub-rococo,bridge-hub-rococo,bridge-hub-westend,collectives-westend,contracts-rococo,coretime-rococo,coretime-westend,glutton-westend,people-rococo,people-westend} ...]]
                  [--pallet [PALLET ...]] [--fail-fast]

options:
  -h, --help            show this help message and exit
  --quiet               Won't print start/end/failed messages in PR
  --clean               Clean up the previous bot's & author's comments in PR
  --image IMAGE         Override docker image '--image
                        docker.io/paritytech/ci-unified:latest'
  --runtime [{dev,westend,rococo,asset-hub-westend,asset-hub-rococo,bridge-hub-rococo,bridge-hub-westend,collectives-westend,contracts-rococo,coretime-rococo,coretime-westend,glutton-westend,people-rococo,people-westend} ...]
                        Runtime(s) space separated
  --pallet [PALLET ...]
                        Pallet(s) space separated
  --fail-fast           Fail fast on first failed benchmark

**Examples**:
 Runs all benchmarks
 /cmd bench

 Runs benchmarks for pallet_balances and pallet_multisig for all runtimes which have these pallets. **--quiet** makes it to output nothing to PR but reactions
 /cmd bench --pallet pallet_balances pallet_xcm_benchmarks::generic --quiet

 Runs bench for all pallets for westend runtime and fails fast on first failed benchmark
 /cmd bench --runtime westend --fail-fast

 Does not output anything and cleans up the previous bot's & author command triggering comments in PR
 /cmd bench --runtime westend rococo --pallet pallet_balances pallet_multisig --quiet --clean


### Command 'fmt'
usage: /cmd fmt [-h] [--quiet] [--clean] [--image IMAGE]

options:
  -h, --help     show this help message and exit
  --quiet        Won't print start/end/failed messages in PR
  --clean        Clean up the previous bot's & author's comments in PR
  --image IMAGE  Override docker image '--image docker.io/paritytech/ci-
                 unified:latest'


### Command 'update-ui'
usage: /cmd update-ui [-h] [--quiet] [--clean] [--image IMAGE]

options:
  -h, --help     show this help message and exit
  --quiet        Won't print start/end/failed messages in PR
  --clean        Clean up the previous bot's & author's comments in PR
  --image IMAGE  Override docker image '--image docker.io/paritytech/ci-
                 unified:latest'


### Command 'prdoc'
usage: /cmd prdoc [-h] [--pr PR]
                  [--audience [{runtime_dev,runtime_user,node_dev,node_operator} ...]]
                  [--bump {patch,minor,major,silent,ignore,no_change}]
                  [--force]

options:
  -h, --help            show this help message and exit
  --pr PR               The PR number to generate the PrDoc for.
  --audience [{runtime_dev,runtime_user,node_dev,node_operator} ...]
                        The audience of whom the changes may concern. Example:
                        --audience runtime_dev node_dev
  --bump {patch,minor,major,silent,ignore,no_change}
                        A default bump level for all crates. Example: --bump
                        patch
  --force               Whether to overwrite any existing PrDoc.

bkontur · 2024-11-18T08:12:59Z

@bkontur I deduplicated the test and extended it to call quote_price_tokens_for_exact_tokens. Please take a look again.

very nice, I am just thinking now, that we could/should split xcm_payment_api_works to two test-cases:

xcm_payment_api_with_native_token_works
xcm_payment_api_with_pools_works

or something like that, because not every runtime has the pools, e.g. coretime/people/relaychains...

franciscoaguirre · 2024-11-20T12:00:01Z

Right now it's in assets/test-utils/. If I divide it in two I can put them in test-utils and use the pools test only in asset hubs

franciscoaguirre · 2024-11-26T12:59:34Z

/cmd fmt

github-actions · 2024-11-26T13:01:34Z

Command "fmt" has started 🚀 See logs here

github-actions · 2024-11-26T13:02:01Z

Command "fmt" has finished ✅ See logs here

paritytech-workflow-stopper · 2024-11-26T13:05:15Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12031120784
Failed job name: fmt

x3c41a · 2024-11-26T13:51:31Z

Cargo.lock

Isn't Cargo.lock supposed to be changed automatically?

It was changed automatically. All the added lines are because I changed dependencies in various crates' Cargo.tomls

fix: query_weight_to_asset_fee was converting locations wrong

ddf87a5

franciscoaguirre requested a review from a team as a code owner November 12, 2024 20:11

franciscoaguirre added 2 commits November 12, 2024 17:11

Merge branch 'master' into fix-xcm-payment-api-conversion

fc0e2df

doc: add prdoc

56ce6d1

".git/.scripts/commands/fmt/fmt.sh"

d76ea78

bkontur assigned bkontur and unassigned bkontur Nov 13, 2024

bkontur approved these changes Nov 13, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/tests/tests.rs Outdated Show resolved Hide resolved

bkontur added A4-needs-backport Pull request must be backported to all maintained releases. T9-cumulus This PR/Issue is related to cumulus. T6-XCM This PR/Issue is related to XCM. labels Nov 13, 2024

bkontur and others added 5 commits November 13, 2024 17:30

Simplify XcmPaymentApi with PoolAdapter (#6467)

f753a7d

Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]>

Merge branch 'master' into fix-xcm-payment-api-conversion

430175b

chore: deduplicate test in asset hub westend and rococo

06f9cc5

test(asset-test-utils): improve the XcmPaymentApi test

90a9539

Merge branch 'master' into fix-xcm-payment-api-conversion

d524701

Update from franciscoaguirre running command 'fmt'

e71fd93

chore: better style

8c627e6

fix: little merge conflict

38d30c1

franciscoaguirre added 3 commits November 26, 2024 09:55

test: include XcmPaymentApi tests in more runtimes

220b06f

fix: zepter

b75aeea

Merge branch 'master' into fix-xcm-payment-api-conversion

2abb8c5

Update from franciscoaguirre running command 'fmt'

e50a0fd

x3c41a self-requested a review November 26, 2024 13:50

x3c41a approved these changes Nov 26, 2024

View reviewed changes

franciscoaguirre self-assigned this Nov 26, 2024

Merge branch 'master' into fix-xcm-payment-api-conversion

5b3f7cb

franciscoaguirre enabled auto-merge November 26, 2024 18:11

franciscoaguirre added this pull request to the merge queue Nov 26, 2024

Any commits made after this event will not be merged.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `XcmPaymentApi::query_weight_to_asset_fee` version conversion #6459

Fix `XcmPaymentApi::query_weight_to_asset_fee` version conversion #6459

franciscoaguirre commented Nov 12, 2024

franciscoaguirre commented Nov 12, 2024

command-bot bot commented Nov 12, 2024 •

edited

Loading

command-bot bot commented Nov 12, 2024

bkontur left a comment

franciscoaguirre commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

franciscoaguirre commented Nov 15, 2024

franciscoaguirre commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

franciscoaguirre commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

bkontur commented Nov 18, 2024

franciscoaguirre commented Nov 20, 2024

franciscoaguirre commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

paritytech-workflow-stopper bot commented Nov 26, 2024

x3c41a Nov 26, 2024

franciscoaguirre Nov 26, 2024

Fix XcmPaymentApi::query_weight_to_asset_fee version conversion #6459

Fix XcmPaymentApi::query_weight_to_asset_fee version conversion #6459

Conversation

franciscoaguirre commented Nov 12, 2024

franciscoaguirre commented Nov 12, 2024

command-bot bot commented Nov 12, 2024 • edited Loading

command-bot bot commented Nov 12, 2024

bkontur left a comment

Choose a reason for hiding this comment

franciscoaguirre commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

franciscoaguirre commented Nov 15, 2024

franciscoaguirre commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

franciscoaguirre commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

bkontur commented Nov 18, 2024

franciscoaguirre commented Nov 20, 2024

franciscoaguirre commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

paritytech-workflow-stopper bot commented Nov 26, 2024

x3c41a Nov 26, 2024

Choose a reason for hiding this comment

franciscoaguirre Nov 26, 2024

Choose a reason for hiding this comment

Fix `XcmPaymentApi::query_weight_to_asset_fee` version conversion #6459

Fix `XcmPaymentApi::query_weight_to_asset_fee` version conversion #6459

command-bot bot commented Nov 12, 2024 •

edited

Loading