xcm-emlator: Use BlockNumberFor instead of parachains_common::BlockNumber=u32 (#4434)
#4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428 (cherry picked from commit 9e0e5fc)
@ntn-x2 yes, cherry-pick is the only way I think :) can you please verify locally all this backports at least with? |
|
@bkontur the tests you mentioned are all ✅✅✅ |
acatangiu
approved these changes
May 17, 2024
acatangiu
merged commit 72dd732
into
paritytech:release-crates-io-v1.1.0
5 of 7 checks passed
This was referenced May 17, 2024
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4496) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4497) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4498) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4499) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4500) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from
master(#4434). Context: #4428.I don't see any other way than opening other PRs for each of the released branches with this fix. If you guys have an alternative proposal, I am all ears. Otherwise, I'll go ahead and open the other ones once this gets merged.