Remove Eq derive for Jacobian for now #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Mar 27, 2020
trevor-crypto
pushed a commit
to monacohq/libsecp256k1
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the derive of
EqonJacobian. It is reported in #42 that it just doesn't work. Jacobian has a scale factorz, where values in Affine would be(x / z^2, y / z^3). Ifzis different, it may represent the same value with differentxs andys.A proper
Eqimplementation in Jacobian may just be converting it to Affine and them do the comparison, but that is not cheap. Unless I figured out a better way, making the conversion explicit for library users, by just removing theEqderive in Jacobian, may be the better idea.