Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting via signed URL #4666

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow exporting via signed URL #4666

wants to merge 2 commits into from

Conversation

brancz
Copy link
Member

@brancz brancz commented May 24, 2024

This patch deprecates the pprof report type for a more generic export type, which both extends the functionality to allow for more formats to be possible in the future as well as allow either serving the download content inline in the response like the pprof report does, or if Parca is configured this way, then upload the export to object storage and serve a download URL that is a signed URL from object storage.

Copy link

alwaysmeticulous bot commented May 24, 2024

🤖 Meticulous spotted visual differences in 1 of 403 screens tested: view and approve differences detected.

Last updated for commit 4dc5e7d. This comment will update as new commits are pushed.

This patch deprecates the pprof report type for a more generic export
type, which both extends the functionality to allow for more formats to
be possible in the future as well as allow either serving the download
content inline in the response like the pprof report does, or if Parca
is configured this way, then upload the export to object storage and
serve a download URL that is a signed URL from object storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant