Fix: deprecations should not raise exceptions (#918)

* Reproduce the #915 bug * Initialize the DeprecationCollector
paratestphp · Dec 10, 2024 · ae3c9f1 · ae3c9f1
1 parent 1ad660c
commit ae3c9f1
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 6 deletions.
diff --git a/src/WrapperRunner/ApplicationForWrapperWorker.php b/src/WrapperRunner/ApplicationForWrapperWorker.php
@@ -15,6 +15,7 @@
 use PHPUnit\Runner\Baseline\CannotLoadBaselineException;
 use PHPUnit\Runner\Baseline\Reader;
 use PHPUnit\Runner\CodeCoverage;
+use PHPUnit\Runner\DeprecationCollector\Facade as DeprecationCollector;
 use PHPUnit\Runner\ErrorHandler;
 use PHPUnit\Runner\Extension\ExtensionBootstrapper;
 use PHPUnit\Runner\Extension\Facade as ExtensionFacade;
@@ -170,12 +171,6 @@ private function bootstrap(): void
             $extensionRequiresCodeCoverageCollection = $extensionFacade->requiresCodeCoverageCollection();
         }
 
-        CodeCoverage::instance()->init(
-            $this->configuration,
-            CodeCoverageFilterRegistry::instance(),
-            $extensionRequiresCodeCoverageCollection,
-        );
-
         if ($this->configuration->hasLogfileJunit()) {
             new JunitXmlLogger(
                 DefaultPrinter::from($this->configuration->logfileJunit()),
@@ -212,6 +207,7 @@ private function bootstrap(): void
         }
 
         TestResultFacade::init();
+        DeprecationCollector::init();
 
         if ($this->configuration->source()->useBaseline()) {
             $baselineFile = $this->configuration->source()->baseline();
@@ -229,6 +225,13 @@ private function bootstrap(): void
         }
 
         EventFacade::instance()->seal();
+
+        CodeCoverage::instance()->init(
+            $this->configuration,
+            CodeCoverageFilterRegistry::instance(),
+            $extensionRequiresCodeCoverageCollection,
+        );
+
         EventFacade::emitter()->testRunnerStarted();
 
         if ($this->configuration->executionOrder() === TestSuiteSorter::ORDER_RANDOMIZED) {

diff --git a/test/Unit/WrapperRunner/WrapperRunnerTest.php b/test/Unit/WrapperRunner/WrapperRunnerTest.php
@@ -756,6 +756,28 @@ public function testBaselineIsRespected(): void
 
 Time: %s, Memory: %s MB
 
+OK%a
+EOF;
+        self::assertStringMatchesFormat($expectedOutput, $runnerResult->output);
+        self::assertEquals(RunnerInterface::SUCCESS_EXIT, $runnerResult->exitCode);
+    }
+
+    #[Group('github')]
+    public function testDeprecationsShouldNotRaiseException(): void
+    {
+        $this->bareOptions['--configuration'] = $this->fixture('github' . DIRECTORY_SEPARATOR . 'GH915' . DIRECTORY_SEPARATOR . 'phpunit.xml');
+
+        $runnerResult = $this->runRunner();
+
+        $expectedOutput = <<<'EOF'
+Processes:     %s
+Runtime:       PHP %s
+Configuration: %s
+
+.                                                                   1 / 1 (100%)
+
+Time: %s, Memory: %s MB
+
 OK%a
 EOF;
         self::assertStringMatchesFormat($expectedOutput, $runnerResult->output);

diff --git a/test/fixtures/github/GH915/IssueTest.php b/test/fixtures/github/GH915/IssueTest.php
@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ParaTest\Tests\fixtures\github\GH915;
+
+use PHPUnit\Framework\TestCase;
+
+/** @internal */
+final class IssueTest extends TestCase
+{
+    public function testasd(): void
+    {
+        self::assertSame(1, 1);
+    }
+}
diff --git a/test/fixtures/github/GH915/phpunit.xml b/test/fixtures/github/GH915/phpunit.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="../../../../vendor/phpunit/phpunit/phpunit.xsd"
+        stopOnDeprecation="true"
+>
+    <testsuites>
+        <testsuite name="Github issue">
+            <file>IssueTest.php</file>
+        </testsuite>
+    </testsuites>
+</phpunit>