Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xcm-api): Remove old XCM API code 👴 #532

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

michaeldev5
Copy link
Collaborator

@michaeldev5 michaeldev5 commented Nov 22, 2024

Closes #440
Closes #441
Closes #471

@michaeldev5 michaeldev5 self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Bundle Report

Changes will decrease total bundle size by 11.74kB (-1.95%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
xcm-analyser-esm 9.32kB 37 bytes (-0.4%) ⬇️
sdk-cjs-esm 431.65kB 10.71kB (-2.42%) ⬇️
xcm-router-esm 149.22kB 994 bytes (-0.66%) ⬇️

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 97.79006% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/sdk/src/pallets/xcmPallet/transfer.ts 60.00% 2 Missing ⚠️
apps/xcm-api/src/balance/balance.service.ts 96.15% 1 Missing ⚠️
...es/sdk/src/pallets/xcmPallet/keepAlive/createTx.ts 66.66% 1 Missing ⚠️
Flag Coverage Δ
visualizator-be 100.00% <ø> (ø)
xcm-analyser 98.60% <ø> (+0.19%) ⬆️
xcm-api 96.60% <98.48%> (-1.19%) ⬇️
xcm-router 92.37% <100.00%> (+0.39%) ⬆️
xcm-sdk 95.24% <97.08%> (-0.76%) ⬇️
Files with missing lines Coverage Δ
apps/xcm-api/src/analytics/EventName.ts 100.00% <ø> (ø)
.../xcm-api/src/asset-claim/asset-claim.controller.ts 100.00% <100.00%> (ø)
...pps/xcm-api/src/asset-claim/asset-claim.service.ts 100.00% <100.00%> (ø)
apps/xcm-api/src/balance/balance.controller.ts 100.00% <100.00%> (ø)
apps/xcm-api/src/router/router.controller.ts 100.00% <100.00%> (ø)
apps/xcm-api/src/router/router.service.ts 100.00% <100.00%> (ø)
...-api/src/transfer-info/transfer-info.controller.ts 100.00% <100.00%> (ø)
...xcm-api/src/transfer-info/transfer-info.service.ts 100.00% <100.00%> (ø)
apps/xcm-api/src/utils.ts 100.00% <ø> (+18.18%) ⬆️
...ps/xcm-api/src/x-transfer/x-transfer.controller.ts 100.00% <100.00%> (ø)
... and 66 more

🚨 Try these New Features:

@michaeldev5 michaeldev5 force-pushed the fix/remove-old-api-code branch 6 times, most recently from b98f5e5 to 677f6aa Compare November 22, 2024 21:22
@michaeldev5 michaeldev5 marked this pull request as ready for review November 22, 2024 22:35
@dudo50 dudo50 merged commit a97b990 into main Nov 23, 2024
14 checks passed
@dudo50 dudo50 deleted the fix/remove-old-api-code branch November 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants