Merge remote-tracking branch 'template/main' into merge-webpack-changes-from-template

[tombogle]

WIP!!! This is my attempt at merging in the vite-> webpack template changes. It currently does not build, and it's possible that I lost important stuff in my attempt to merge. It's more than likely that I have some major things wrong.

Conflicts:

.gitignore

.vscode/launch.json

.vscode/settings.json

README.md

package-lock.json

package.json

public/manifest.json

tsconfig.json

---

This change is 

[rolfheij-sil]

Nice work. Great that you were able to resolve the merge conflicts

Reviewed 26 of 26 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tombogle)

---

public/assets/heresy-warning.txt line 1 at r1 (raw file):

Heresy count:

I think this file can be deleted

---

src/main.ts line 176 at r1 (raw file):

        logger.info(`Tim sneezed the ${timSneeze[timSneeze.length - 1].sneezeId} sneeze`),
    );
    context.registrations.add(unsubGreetings);

The use of this section of code is unclear to me. I know it's not your code, but what is it supposed to do?

[tombogle]

src/main.ts line 176 at r1 (raw file):

Previously, rolfheij-sil wrote…

The use of this section of code is unclear to me. I know it's not your code, but what is it supposed to do?

It is kind of "my code" (closely supervised by TJ). Changed the comment to try to clarify its purpose.

[tombogle]

Reviewable status: 24 of 26 files reviewed, 2 unresolved discussions (waiting on @rolfheij-sil)

---

public/assets/heresy-warning.txt line 1 at r1 (raw file):

Previously, rolfheij-sil wrote…

I think this file can be deleted

Done.

[rolfheij-sil]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)

---

src/main.ts line 176 at r1 (raw file):

Previously, tombogle (Tom Bogle) wrote…

It is kind of "my code" (closely supervised by TJ). Changed the comment to try to clarify its purpose.

Thanks for updating the comment. I was reffering to the code above, where it seems that some sort of test-sneeze is configured to be added on unsubscribing, or something like that? I still don't get it 😆

[rolfheij-sil]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)

[tombogle]

src/main.ts line 176 at r1 (raw file):

Previously, rolfheij-sil wrote…

Thanks for updating the comment. I was reffering to the code above, where it seems that some sort of test-sneeze is configured to be added on unsubscribing, or something like that? I still don't get it 😆

Yeah, I was unclear on that also and asked TJ. He wasn't 100% sure, but looking at it we surmised that we're subscribing to be notified any time Tim sneezes. If you don't know, then I guess maybe Katherine or maybe Tim must be the mastermind responsible for that code. I could comment it based on our educated guess...