Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MandatoryProjectDataType JSDoc to match current type enforcement #690

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

tjcouch-sil
Copy link
Member

@tjcouch-sil tjcouch-sil commented Dec 20, 2023

While designing #540, Tim and I realized that we aren't actually enforcing the parameter types on the PDP ExtensionData type, so we decided to document the situation a bit more clearly.


This change is Reviewable

@tjcouch-sil tjcouch-sil requested a review from lyonsil December 20, 2023 22:13
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tjcouch-sil tjcouch-sil merged commit c15dc2e into main Dec 21, 2023
7 checks passed
@tjcouch-sil tjcouch-sil deleted the 540-scripture-token-design branch December 21, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants