Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useDataProviderMulti hook #561

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add useDataProviderMulti hook #561

merged 1 commit into from
Oct 18, 2023

Conversation

lyonsil
Copy link
Member

@lyonsil lyonsil commented Oct 17, 2023

This change is Reviewable

@lyonsil lyonsil force-pushed the 371-use-data-provider-multi branch 2 times, most recently from 8fc3500 to 3d8df8a Compare October 18, 2023 15:19
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! I'm excited for this! My only request is a JSDoc comment :)

Reviewed 2 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lyonsil)


src/renderer/hooks/papi-hooks/use-data-provider-multi.hook.ts line 8 at r1 (raw file):

// eslint-disable-next-line @typescript-eslint/no-explicit-any
function useDataProviderMulti<T extends IDataProvider<any>[]>(

I think it would be good to have a JSDoc comment here. Also it would be good to copy over the comment explaining the rule disable from useDataProvider :) thanks!

Maybe worth mentioning the issue with types when you specify different data providers, too.

@lyonsil lyonsil force-pushed the 371-use-data-provider-multi branch from 3d8df8a to 9b48d81 Compare October 18, 2023 17:12
Copy link
Member Author

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @tjcouch-sil)


src/renderer/hooks/papi-hooks/use-data-provider-multi.hook.ts line 8 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

I think it would be good to have a JSDoc comment here. Also it would be good to copy over the comment explaining the rule disable from useDataProvider :) thanks!

Maybe worth mentioning the issue with types when you specify different data providers, too.

Yep - I was so focused on the code I forgot about the JSDoc comments. Fixed.

@lyonsil lyonsil enabled auto-merge (squash) October 18, 2023 17:45
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the hard work on this!

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lyonsil lyonsil merged commit c969022 into main Oct 18, 2023
6 checks passed
@lyonsil lyonsil deleted the 371-use-data-provider-multi branch October 18, 2023 18:03
@lyonsil lyonsil linked an issue Oct 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects: create useDataProviderMulti hook
2 participants