Update the icons with the new official icon. Removed pt-summit icon. #414
Conversation
There was a problem hiding this comment.
That was fast, nice work!
Would it be a good idea to rename them to pb-*? I guess pt still refers to Paratext
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @FoolRunning)
assets-excluded/logo/pt-react.png line 0 at r1 (raw file):
The new image is smaller, is that okay?
It's 256256 instead of 10241024
c-sharp/icon.ico line 0 at r1 (raw file):
This one is smaller too.
It's 256256 instead of 10241024
…ssed before. Removed unused .svg icon.
There was a problem hiding this comment.
Good point. I just removed the prefix.
Reviewable status: 5 of 12 files reviewed, 2 unresolved discussions (waiting on @rolfheij-sil)
c-sharp/icon.ico line at r1 (raw file):
Previously, rolfheij-sil wrote…
This one is smaller too.
It's 256256 instead of 10241024
256x256 is the biggest we have. That should be big enough (at least for now).
assets-excluded/logo/pt-react.png line at r1 (raw file):
Previously, rolfheij-sil wrote…
The new image is smaller, is that okay?
It's 256256 instead of 10241024
256x256 is the biggest we have. That should be big enough (at least for now).
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
|
The build failed because apparently it does need at least a 512x512 image. I've asked if one can be gotten. |
There was a problem hiding this comment.
Reviewed 5 of 9 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @FoolRunning)
assets/icon.svg line 1 at r2 (raw file):
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
I think you will find this file gets used in production for the macOS release.
c-sharp/icon.ico line 0 at r2 (raw file):
Is this an .ico containing several different sizes (the same sizes contained int he old one)?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @irahopkinson)
assets/icon.svg line 1 at r2 (raw file):
Previously, irahopkinson (Ira Hopkinson) wrote…
I think you will find this file gets used in production for the macOS release.
I searched all files and could find no reference to any .svg file, but maybe I missed something?
c-sharp/icon.ico line at r2 (raw file):
Previously, irahopkinson (Ira Hopkinson) wrote…
Is this an
.icocontaining several different sizes (the same sizes contained int he old one)?
It does contain multiple sizes (max size 256x256). I'm not sure which ones were in the original.
|
Previously, FoolRunning (Tim Steenwyk) wrote…
electron-builder doesn't refer to it directly - it just expects it to exist with that filename (I think you can specify it which, in hind-sight, would be a better setup to make it more obvious it's being used). However, I'm not remembering correctly and the file I'm thinking of is the |
|
Previously, irahopkinson (Ira Hopkinson) wrote…
We still might want to keep this file since it's the only format that we can use in a browser that doesn't need the different sizes cached. Perhaps move it into |
There was a problem hiding this comment.
Reviewed 5 of 9 files at r1, 7 of 7 files at r2, 8 of 8 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @FoolRunning and @irahopkinson)
There was a problem hiding this comment.
The main window icon is lower res than the rest (panel icons) but we can fix that up as we go along rather than hold this up.
Reviewed 8 of 8 files at r3, all commit messages.
Reviewable status:
This change is