Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix search width #1413

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix search width #1413

wants to merge 2 commits into from

Conversation

Sebastian-ubs
Copy link
Contributor

@Sebastian-ubs Sebastian-ubs commented Dec 20, 2024 •
edited
Loading

Fixes the search bar

  • width / placement of x button now always inside of the input
  • accessibility: onClick on the x button instead of the icon

This is a breaking change for (potential) extensions that use TabNavigationContentSearch together with the optional isSearchBarfullWidth parameter as this was removed in favor of the more flexible searchClassName.
I'm not aware of extensions that use TabNavigationContentSearch .

Before
396903843-d34dd81e-32f3-436f-a2fc-e101f9c012db

After
image

This change is Reviewable

@Sebastian-ubs Sebastian-ubs linked an issue Dec 20, 2024 that may be closed by this pull request
SearchBar layout is broken #1405
Open
@Sebastian-ubs Sebastian-ubs force-pushed the 1405-SearchBar-layout-is-broken branch from a93e505 to 8556eec Compare December 20, 2024 17:05
@Sebastian-ubs Sebastian-ubs force-pushed the 1405-SearchBar-layout-is-broken branch from e567abb to 9363bdc Compare December 20, 2024 17:37
@Sebastian-ubs Sebastian-ubs enabled auto-merge (squash) December 20, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SearchBar layout is broken
1 participant
@Sebastian-ubs