Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MultiSelectComboBox placeholder color #1374

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

Sebastian-ubs
Copy link
Contributor

@Sebastian-ubs Sebastian-ubs commented Dec 6, 2024

MultiSelectComboBox placeholder was wrongly using muted instead of muted-foreground. Also was not good for hover.
Screenshot 2024-12-06 135000
Screenshot 2024-12-06 135009

Fix is
Screenshot 2024-12-06 134947
Screenshot 2024-12-06 134937


This change is Reviewable

@Sebastian-ubs Sebastian-ubs marked this pull request as draft December 6, 2024 12:48
@Sebastian-ubs
Copy link
Contributor Author

@rolfheij fyi

@rolfheij-sil
Copy link
Contributor

Thanks for taking care of this!
(Also please not that @rolfheij is my private account, and @rolfheij-sil is my work account 😁 I guess I'll change my private account username at some point)

rolfheij-sil
rolfheij-sil previously approved these changes Dec 6, 2024
Copy link
Contributor

@rolfheij-sil rolfheij-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Sebastian-ubs
Copy link
Contributor Author

@rolfheij is my private account,

sorry 😬

@Sebastian-ubs Sebastian-ubs marked this pull request as ready for review December 11, 2024 12:07
@Sebastian-ubs Sebastian-ubs enabled auto-merge (squash) December 11, 2024 12:07
Copy link
Contributor

@rolfheij-sil rolfheij-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!
:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Sebastian-ubs Sebastian-ubs merged commit c12a503 into main Dec 11, 2024
7 checks passed
@Sebastian-ubs Sebastian-ubs deleted the fix-input-styles branch December 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants