security updatescripture-utilities
#1332
Conversation
There was a problem hiding this comment.
I don't know what's going wrong here. It looks good to me 🤔
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
- also use USJ `const`s in editor extension
irahopkinson
force-pushed
the
update-utilities
branch
from
3df942a to
156fa77
Compare
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @irahopkinson)
extensions/src/legacy-comment-manager/package.json line 37 at r2 (raw file):
}, "dependencies": { "@biblionexus-foundation/scripture-utilities": "~0.0.5",
Does the tilde ~ mean only update to newer patch versions? Why choose this option if so?
|
Previously, tjcouch-sil (TJ Couch) wrote…
I put a a fuller explanation in our DM in Discord. |
consts in editor extensionNote
This PR was draft because there was still one copy of
@biblionexus-foundation/scripture-utilitiesat v0.0.4. This is now fixed. Note there is a way to override npm to fix this (see commit 2 which will be squashed on merge) but it is properly fixed in@biblionexus-foundation/[email protected]This change is