Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing format checks #1318

Merged
merged 18 commits into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c9f6f2e
Squashed 'extensions/' changes from fddfe3be5..c276fc9e7
irahopkinson Nov 20, 2024
2af9a8d
Merge commit 'c9f6f2eef5ec87b7766f665bda9df65072802dfc' into format-c…
irahopkinson Nov 20, 2024
1b89194
Squashed 'extensions/src/hello-someone/' changes from 8902864fa..93d4…
irahopkinson Nov 20, 2024
231fb12
Merge commit '1b89194c2b261238b05056f2491fc970aa6d23a3' into format-c…
irahopkinson Nov 20, 2024
5ab00b5
Squashed 'extensions/src/hello-world/' changes from 8902864fa..93d4b0a63
irahopkinson Nov 20, 2024
b3d5efa
Merge commit '5ab00b5135c2b345320237d0ca545eacbf05e92c' into format-c…
irahopkinson Nov 20, 2024
3ebc697
Squashed 'extensions/src/legacy-comment-manager/' changes from 890286…
irahopkinson Nov 20, 2024
88b34c4
Merge commit '3ebc69740b56f5dd547f4d48fbae9c5ec2fea71c' into format-c…
irahopkinson Nov 20, 2024
1a90198
Squashed 'extensions/src/paratext-registration/' changes from 8902864…
irahopkinson Nov 20, 2024
9e240b3
Merge commit '1a90198084b8957c68cf98191074fe0bd449a665' into format-c…
irahopkinson Nov 20, 2024
ddb3d23
Squashed 'extensions/src/platform-scripture/' changes from 8902864fa.…
irahopkinson Nov 20, 2024
7f02cda
Merge commit 'ddb3d23b3385f6650ff7d2f0a435186e7faf0e41' into format-c…
irahopkinson Nov 20, 2024
bf9981d
Squashed 'extensions/src/platform-scripture-editor/' changes from 890…
irahopkinson Nov 20, 2024
23a7f69
Merge commit 'bf9981d51e35fb703257d9224a557d51f5edf825' into format-c…
irahopkinson Nov 20, 2024
20a4e71
Squashed 'extensions/src/quick-verse/' changes from 8902864fa..93d4b0a63
irahopkinson Nov 20, 2024
e80cab8
Merge commit '20a4e718b399153174fdfba9be3e177d9bf6ff01' into format-c…
irahopkinson Nov 20, 2024
d40368d
add missing format checks
irahopkinson Nov 19, 2024
7a71b35
add missing typechecks
irahopkinson Nov 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extensions/.stylelintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ module.exports = {
},
],
rules: {
// Disable Stylelint's indentation control
'@stylistic/indentation': null,
// Let Prettier handle selector list formatting
'@stylistic/selector-list-comma-newline-after': null,
'color-named': null,
'max-nesting-depth': 2,
'no-descending-specificity': null,
Expand Down
4 changes: 3 additions & 1 deletion extensions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
"watch": "npm run build -- --watch",
"build:production": "cross-env NODE_ENV=production TS_NODE_TRANSPILE_ONLY=false webpack",
"watch:production": "npm run build:production -- --watch",
"format": "prettier --write .",
"format:check": "prettier --check .",
"zip": "tsx ./lib/zip-extensions.ts",
"package": "npm run build:production && npm run zip",
"package:debug": "cross-env DEBUG_PROD=true npm run package",
Expand All @@ -21,7 +23,7 @@
"lint:scripts": "cross-env NODE_OPTIONS=\"--max-old-space-size=4096\" NODE_ENV=development eslint --ext .cjs,.js,.jsx,.ts,.tsx --cache .",
"lint:styles": "stylelint **/*.{css,scss}",
"lint-fix": "npm run lint-fix:scripts && npm run lint:styles -- --fix",
"lint-fix:scripts": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint:scripts",
"lint-fix:scripts": "npm run format && npm run lint:scripts",
"lint:staged": "lint-staged -q",
"postinstall": "tsx ./lib/add-remotes.ts",
"create-extension": "tsx ./lib/create-extension.ts",
Expand Down
2 changes: 1 addition & 1 deletion extensions/src/evil/assets/evil.web-view.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<body>
<script>
Expand Down
4 changes: 4 additions & 0 deletions extensions/src/hello-someone/.stylelintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ module.exports = {
},
],
rules: {
// Disable Stylelint's indentation control
'@stylistic/indentation': null,
// Let Prettier handle selector list formatting
'@stylistic/selector-list-comma-newline-after': null,
'color-named': null,
'max-nesting-depth': 2,
'no-descending-specificity': null,
Expand Down
4 changes: 3 additions & 1 deletion extensions/src/hello-someone/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"watch": "npm run build -- --watch",
"build:production": "cross-env NODE_ENV=production TS_NODE_TRANSPILE_ONLY=false webpack",
"watch:production": "npm run build:production -- --watch",
"format": "prettier --write .",
"format:check": "prettier --check .",
"zip": "zip-build dist release --template '%NAME%_%VERSION%.%EXT%' --override",
"package": "npm run build:production && npm run zip",
"package:debug": "cross-env DEBUG_PROD=true npm run package",
Expand All @@ -23,7 +25,7 @@
"lint:scripts": "eslint --ext .cjs,.js,.jsx,.ts,.tsx --cache .",
"lint:styles": "stylelint **/*.{css,scss}",
"lint-fix": "npm run lint-fix:scripts && npm run lint:styles -- --fix",
"lint-fix:scripts": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint:scripts",
"lint-fix:scripts": "npm run format && npm run lint:scripts",
"typecheck": "tsc -p ./tsconfig.json"
},
"browserslist": [],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head> </head>
<body>
Expand Down
4 changes: 4 additions & 0 deletions extensions/src/hello-world/.stylelintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ module.exports = {
},
],
rules: {
// Disable Stylelint's indentation control
'@stylistic/indentation': null,
// Let Prettier handle selector list formatting
'@stylistic/selector-list-comma-newline-after': null,
'color-named': null,
'max-nesting-depth': 2,
'no-descending-specificity': null,
Expand Down
4 changes: 3 additions & 1 deletion extensions/src/hello-world/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"watch": "npm run build -- --watch",
"build:production": "cross-env NODE_ENV=production TS_NODE_TRANSPILE_ONLY=false webpack",
"watch:production": "npm run build:production -- --watch",
"format": "prettier --write .",
"format:check": "prettier --check .",
"zip": "zip-build dist release --template '%NAME%_%VERSION%.%EXT%' --override",
"package": "npm run build:production && npm run zip",
"package:debug": "cross-env DEBUG_PROD=true npm run package",
Expand All @@ -23,7 +25,7 @@
"lint:scripts": "eslint --ext .cjs,.js,.jsx,.ts,.tsx --cache .",
"lint:styles": "stylelint **/*.{css,scss}",
"lint-fix": "npm run lint-fix:scripts && npm run lint:styles -- --fix",
"lint-fix:scripts": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint:scripts",
"lint-fix:scripts": "npm run format && npm run lint:scripts",
"typecheck": "tsc -p ./tsconfig.json"
},
"browserslist": [],
Expand Down
4 changes: 4 additions & 0 deletions extensions/src/legacy-comment-manager/.stylelintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ module.exports = {
},
],
rules: {
// Disable Stylelint's indentation control
'@stylistic/indentation': null,
// Let Prettier handle selector list formatting
'@stylistic/selector-list-comma-newline-after': null,
'color-named': null,
'max-nesting-depth': 2,
'no-descending-specificity': null,
Expand Down
5 changes: 4 additions & 1 deletion extensions/src/legacy-comment-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"watch": "npm run build -- --watch",
"build:production": "cross-env NODE_ENV=production TS_NODE_TRANSPILE_ONLY=false webpack",
"watch:production": "npm run build:production -- --watch",
"format": "prettier --write .",
"format:check": "prettier --check .",
"zip": "zip-build dist release --template '%NAME%_%VERSION%.%EXT%' --override",
"package": "npm run build:production && npm run zip",
"package:debug": "cross-env DEBUG_PROD=true npm run package",
Expand All @@ -23,7 +25,8 @@
"lint:scripts": "eslint --ext .cjs,.js,.jsx,.ts,.tsx --cache .",
"lint:styles": "stylelint **/*.{css,scss}",
"lint-fix": "npm run lint-fix:scripts && npm run lint:styles -- --fix",
"lint-fix:scripts": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint:scripts"
"lint-fix:scripts": "npm run format && npm run lint:scripts",
"typecheck": "tsc -p ./tsconfig.json"
},
"browserslist": [],
"peerDependencies": {
Expand Down
4 changes: 4 additions & 0 deletions extensions/src/paratext-registration/.stylelintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ module.exports = {
},
],
rules: {
// Disable Stylelint's indentation control
'@stylistic/indentation': null,
// Let Prettier handle selector list formatting
'@stylistic/selector-list-comma-newline-after': null,
'color-named': null,
'max-nesting-depth': 2,
'no-descending-specificity': null,
Expand Down
Loading
Loading