improve linting #1306
Merged
improve linting #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcouch-sil
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
fddfe3be5 improve linting (#31) git-subtree-dir: extensions git-subtree-split: fddfe3be5b8aa13896dc23062a89918a730efcd4
…864fa 8902864fa improve linting (#85) git-subtree-dir: extensions/src/hello-someone git-subtree-split: 8902864faf945d80c48def6ba5e728cbe677de58
8902864fa improve linting (#85) git-subtree-dir: extensions/src/hello-world git-subtree-split: 8902864faf945d80c48def6ba5e728cbe677de58
…6fc..8902864fa 8902864fa improve linting (#85) git-subtree-dir: extensions/src/legacy-comment-manager git-subtree-split: 8902864faf945d80c48def6ba5e728cbe677de58
…fc..8902864fa 8902864fa improve linting (#85) git-subtree-dir: extensions/src/paratext-registration git-subtree-split: 8902864faf945d80c48def6ba5e728cbe677de58
….8902864fa 8902864fa improve linting (#85) git-subtree-dir: extensions/src/platform-scripture git-subtree-split: 8902864faf945d80c48def6ba5e728cbe677de58
…51c6fc..8902864fa 8902864fa improve linting (#85) git-subtree-dir: extensions/src/platform-scripture-editor git-subtree-split: 8902864faf945d80c48def6ba5e728cbe677de58
8902864fa improve linting (#85) git-subtree-dir: extensions/src/quick-verse git-subtree-split: 8902864faf945d80c48def6ba5e728cbe677de58
- use the TS version of `class-methods-use-this` so we can ignore override methods.
irahopkinson
force-pushed
the
improve-lint
branch
from
51c8c52 to
3ea429c
Compare
|
Neither did I but I suspected a TS version might be able to do better so I had a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class-methods-use-thisso we can ignore override methods.Note
import/no-anonymous-default-exportwas moved to it's alphabetical location.ignoreClassesThatImplementAnInterfaceis explicitly false as it will ignore ALL methods if a class implements an interface, not just the ones in the interface. Eslint exception comments will keep these intentional.This change is