Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use npm ci in GHA #1274

Merged
merged 1 commit into from
Nov 7, 2024
Merged

use npm ci in GHA #1274

merged 1 commit into from
Nov 7, 2024

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Nov 7, 2024 •
edited
Loading

  • identifies inconsistencies between package.json and package-lock.json before it reaches PT10S builds

This change is Reviewable

@irahopkinson
use npm ci in GHA
42c4195 
- identifies inconsistencies between `package.json` and `package-lock.json` before it reaches PT10S builds
@irahopkinson irahopkinson enabled auto-merge (squash) November 7, 2024 22:17
lyonsil
lyonsil approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: good suggestion

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@irahopkinson irahopkinson merged commit 6eb9d8f into main Nov 7, 2024
7 checks passed
@irahopkinson irahopkinson deleted the npm-ci branch November 7, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyonsil lyonsil lyonsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irahopkinson @lyonsil