Skip to content

Commit

Permalink
add missing format checks
Browse files Browse the repository at this point in the history
- fix format errors
- also `npm audit fix`
  • Loading branch information
irahopkinson committed Nov 20, 2024
1 parent cba0e36 commit c489d5d
Show file tree
Hide file tree
Showing 15 changed files with 136 additions and 118 deletions.
4 changes: 4 additions & 0 deletions extensions/.stylelintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ module.exports = {
},
],
rules: {
// Disable Stylelint's indentation control
'@stylistic/indentation': null,
// Let Prettier handle selector list formatting
'@stylistic/selector-list-comma-newline-after': null,
'color-named': null,
'max-nesting-depth': 2,
'no-descending-specificity': null,
Expand Down
4 changes: 3 additions & 1 deletion extensions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
"watch": "npm run build -- --watch",
"build:production": "cross-env NODE_ENV=production TS_NODE_TRANSPILE_ONLY=false webpack",
"watch:production": "npm run build:production -- --watch",
"format": "prettier --write .",
"format:check": "prettier --check .",
"zip": "tsx ./lib/zip-extensions.ts",
"package": "npm run build:production && npm run zip",
"package:debug": "cross-env DEBUG_PROD=true npm run package",
Expand All @@ -21,7 +23,7 @@
"lint:scripts": "cross-env NODE_OPTIONS=\"--max-old-space-size=4096\" NODE_ENV=development eslint --ext .cjs,.js,.jsx,.ts,.tsx --cache .",
"lint:styles": "stylelint **/*.{css,scss}",
"lint-fix": "npm run lint-fix:scripts && npm run lint:styles -- --fix",
"lint-fix:scripts": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint:scripts",
"lint-fix:scripts": "npm run format && npm run lint:scripts",
"lint:staged": "lint-staged -q",
"postinstall": "tsx ./lib/add-remotes.ts",
"create-extension": "tsx ./lib/create-extension.ts",
Expand Down
2 changes: 1 addition & 1 deletion extensions/src/evil/assets/evil.web-view.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<body>
<script>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head> </head>
<body>
Expand Down
4 changes: 4 additions & 0 deletions extensions/src/platform-scripture-editor/.stylelintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ module.exports = {
},
],
rules: {
// Disable Stylelint's indentation control
'@stylistic/indentation': null,
// Let Prettier handle selector list formatting
'@stylistic/selector-list-comma-newline-after': null,
'color-named': null,
'max-nesting-depth': 2,
'no-descending-specificity': null,
Expand Down
6 changes: 3 additions & 3 deletions extensions/src/platform-scripture-editor/src/_commenting.scss
Original file line number Diff line number Diff line change
Expand Up @@ -500,15 +500,15 @@ i.send {
}

.CommentPlugin_CommentsPanel_List_Thread_Comments
.CommentPlugin_CommentsPanel_List_Comment:first-child {
.CommentPlugin_CommentsPanel_List_Comment:first-child {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
border: none;
margin-left: 0;
padding-left: 5px;
}

.CommentPlugin_CommentsPanel_List_Thread_Comments
.CommentPlugin_CommentsPanel_List_Comment:first-child.CommentPlugin_CommentsPanel_List_Comment:last-child {
.CommentPlugin_CommentsPanel_List_Comment:first-child.CommentPlugin_CommentsPanel_List_Comment:last-child {
padding-bottom: 5px;
}

Expand Down Expand Up @@ -536,7 +536,7 @@ i.send {
.CommentPlugin_CommentsPanel_DeletedComment,
.CommentPlugin_CommentsPanel_List_Comment:hover .CommentPlugin_CommentsPanel_List_DeleteButton,
.CommentPlugin_CommentsPanel_List_Thread_QuoteBox:hover
.CommentPlugin_CommentsPanel_List_DeleteButton {
.CommentPlugin_CommentsPanel_List_DeleteButton {
opacity: 0.5;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ button.toolbar-item {
.CommentPlugin_CommentsPanel_DeletedComment,
.CommentPlugin_CommentsPanel_List_Comment:hover .CommentPlugin_CommentsPanel_List_DeleteButton,
.CommentPlugin_CommentsPanel_List_Thread_QuoteBox:hover
.CommentPlugin_CommentsPanel_List_DeleteButton {
.CommentPlugin_CommentsPanel_List_DeleteButton {
filter: unset;
opacity: unset;
}
Expand Down
1 change: 0 additions & 1 deletion extensions/src/platform-scripture-editor/src/_editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,6 @@ i.redo {
background-image: url('/assets/images/icons/type-h3.svg');
}


.icon.mt,
.icon.mt1,
.icon.square-1 {
Expand Down
Loading

0 comments on commit c489d5d

Please sign in to comment.